Skip to content

feat: Export getSpanDescendants() everywhere #10924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 6, 2024
Merged

feat: Export getSpanDescendants() everywhere #10924

merged 1 commit into from
Mar 6, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented Mar 5, 2024

This can be used instead of spanRecorder going forward.

@mydea mydea requested a review from lforst March 5, 2024 11:03
@mydea mydea self-assigned this Mar 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 5, 2024 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 77.37 KB (-0.02% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 68.58 KB (-0.01% 🔽)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 72.5 KB (0%)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 62.14 KB (-0.01% 🔽)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 32.84 KB (0%)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 32.84 KB (0%)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.34 KB (-0.02% 🔽)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.35 KB (0%)
@sentry/browser - Webpack (gzipped) 22.56 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 75.48 KB (+0.07% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 67.11 KB (+0.1% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 32.98 KB (+0.23% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 24.07 KB (+0.4% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 210.65 KB (+0.06% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 99.51 KB (+0.18% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 71.79 KB (+0.2% 🔺)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 36.11 KB (+0.18% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 68.87 KB (-0.01% 🔽)
@sentry/react - Webpack (gzipped) 22.59 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 85.29 KB (-0.01% 🔽)
@sentry/nextjs Client - Webpack (gzipped) 49.7 KB (0%)
@sentry-internal/feedback - Webpack (gzipped) 17.4 KB (-0.04% 🔽)

@krystofwoldrich
Copy link
Contributor

I assume this will be exported in v8?

@mydea mydea force-pushed the fn/getSpanDescendants branch from 7e8ceaa to 763bc4b Compare March 5, 2024 16:16
@mydea
Copy link
Member Author

mydea commented Mar 6, 2024

I assume this will be exported in v8?

Yes, this PR should export this everywhere so this can be used instead of span recorder! :)

@mydea mydea merged commit 1cdab67 into develop Mar 6, 2024
@mydea mydea deleted the fn/getSpanDescendants branch March 6, 2024 09:56
@AbhiPrasad AbhiPrasad mentioned this pull request Mar 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

@lforst lforst Awaiting requested review from lforst

Assignees

@mydea mydea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mydea @krystofwoldrich @AbhiPrasad