build(bundles): Use ES2017 for bundles (drop ES5 support) #10911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
mydea
reviewed
Mar 6, 2024
mydea
approved these changes
Mar 6, 2024
There was a problem hiding this comment.
This all looks really good to me!
let's also add an entry into MIGRATION.md, indicating that ES5 is not supported anymore, and users need to polyfill stuff themselves if they want to continue supporting ES5.
Also, let's wait for another review from e.g. @AbhiPrasad to have a second set of eyes on this as well :)
|
After that we can also remove the promise like stuff etc 🎉 |
@mydea This should be covered here in MIGRATION.md: https://github.com/getsentry/sentry-javascript/pull/10911/files#diff-c1603ee6a674bb75255aa448057630506153e363297fd58668e6679f10909bc6L27-L40 Or should we be more specific on that? |
|
Ahh you are right of course, we already added this in advance - all good then :D |
AbhiPrasad
approved these changes
Mar 6, 2024
| @@ -24,7 +24,7 @@ stable release of `8.x` comes out). | |||
| `@sentry/node` and all of our node-based server-side sdks (`@sentry/nextjs`, `@sentry/serverless`, etc.). We no longer | |||
| test against Node 8, 10, or 12 and cannot guarantee that the SDK will work as expected on these versions. | |||
|
|
|||
| **Browser**: Our browser SDKs (`@sentry/browser`, `@sentry/react`, `@sentry/vue`, etc.) now require ES6+ compatible | |||
There was a problem hiding this comment.
We should double check if the browser listed below are still accurate here - caniuse is here
s1gr1d
added a commit
to getsentry/sentry
that referenced
this pull request
Mar 13, 2024
As the coming version of the JS SDK only uses ES2017 bundles, it is no longer necessary to differentiate between es5 and es6 bundles. ref getsentry/sentry-javascript#10911
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #9829