Skip to content

feat(browser): Exclude span exports from non-performance CDN bundles #10879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented Mar 1, 2024

I figured we don't actually need to expor these (e.g. startSpan, etc.) in non-performance CDN bundles.

We can think about providing shims for these, but honestly not so sure 🤔

@mydea mydea requested review from lforst, Lms24 and AbhiPrasad March 1, 2024 08:53
@mydea mydea self-assigned this Mar 1, 2024
Copy link
Contributor

github-actions bot commented Mar 1, 2024

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 77.21 KB (-0.25% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 68.46 KB (-0.22% 🔽)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 72.4 KB (-0.21% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 62.01 KB (-0.26% 🔽)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 32.67 KB (-0.53% 🔽)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 32.67 KB (-0.53% 🔽)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.02 KB (-0.15% 🔽)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.02 KB (-0.13% 🔽)
@sentry/browser - Webpack (gzipped) 22.27 KB (-0.12% 🔽)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 75.37 KB (-0.61% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 67.03 KB (-0.63% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 32.87 KB (-1.26% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped) 23.85 KB (-3.8% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 210.31 KB (-0.37% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 99.04 KB (-0.77% 🔽)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 71.07 KB (-4.06% 🔽)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 35.95 KB (-1.12% 🔽)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 68.74 KB (-0.2% 🔽)
@sentry/react - Webpack (gzipped) 22.3 KB (-0.11% 🔽)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 85.19 KB (-0.21% 🔽)
@sentry/nextjs Client - Webpack (gzipped) 49.53 KB (-0.33% 🔽)
@sentry-internal/feedback - Webpack (gzipped) 17.09 KB (0%)

@mydea mydea force-pushed the fn/span-exports-cdn-bundle branch from 5e89d47 to 79a4d1c Compare March 1, 2024 09:02
Copy link
Member

@s1gr1d s1gr1d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@mydea mydea force-pushed the fn/span-exports-cdn-bundle branch from 79a4d1c to 91b9c2d Compare March 4, 2024 14:19
@AbhiPrasad
Copy link
Member

IMO we probably have to shim this because we don't want sites to break when they flip flags in the UI :/

@mydea mydea merged commit ff918f0 into develop Mar 4, 2024
@mydea mydea deleted the fn/span-exports-cdn-bundle branch March 4, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants