ref(sveltekit): Update trace propagation & span options #10838
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mydea
force-pushed
the
fn/sveltekit-trace-propagation
branch
from
929f39a to
e9e0aee
Compare
mydea
changed the title
mydea
force-pushed
the
fn/sveltekit-trace-propagation
branch
from
e9e0aee to
42ea214
Compare
Lms24
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This WIP updates sveltekit to avoid deprecated options to
startSpan, which also includes changing how we propagate traces to usecontinueTrace.I fixed the tests to ensure this still works, but would appreciate a review from @Lms24 if that all seems correct 😅