Skip to content

feat(v8/core): remove void from transport return #10794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Mar 4, 2024
Merged

feat(v8/core): remove void from transport return #10794

merged 9 commits into from
Mar 4, 2024

Conversation

AbhiPrasad
Copy link
Member

@AbhiPrasad AbhiPrasad commented Feb 22, 2024 •
edited
Loading

Use Promise<TransportMakeRequestResponse> instead of Promise<void | TransportMakeRequestResponse>. As a result, remove __sentry__baseTransport__ field from transports.

@AbhiPrasad AbhiPrasad requested review from timfish and a team February 22, 2024 15:49
@AbhiPrasad AbhiPrasad self-assigned this Feb 22, 2024
@AbhiPrasad AbhiPrasad requested review from stephanie-anderson and lforst and removed request for a team February 22, 2024 15:49
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 22, 2024 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 77.15 KB (-0.08% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 68.38 KB (-0.13% 🔽)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 72.31 KB (-0.12% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 61.93 KB (-0.13% 🔽)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 32.65 KB (-0.07% 🔽)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 32.65 KB (-0.07% 🔽)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31 KB (-0.04% 🔽)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.01 KB (-0.02% 🔽)
@sentry/browser - Webpack (gzipped) 22.25 KB (-0.13% 🔽)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 75.3 KB (-0.09% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 66.95 KB (-0.13% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 32.83 KB (-0.1% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped) 23.82 KB (-0.13% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 210.15 KB (-0.08% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 99.01 KB (-0.04% 🔽)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 71.02 KB (-0.07% 🔽)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 35.92 KB (-0.07% 🔽)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 68.66 KB (-0.12% 🔽)
@sentry/react - Webpack (gzipped) 22.28 KB (-0.13% 🔽)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 85.11 KB (-0.1% 🔽)
@sentry/nextjs Client - Webpack (gzipped) 49.51 KB (-0.05% 🔽)
@sentry-internal/feedback - Webpack (gzipped) 17.1 KB (+0.06% 🔺)

Lms24
Lms24 approved these changes Feb 23, 2024
View reviewed changes
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@lforst
Copy link
Contributor

lforst commented Feb 23, 2024

Do we need to write an entry in the migration guide for this?

@AbhiPrasad
Copy link
Member Author

Do we need to write an entry in the migration guide for this?

yes! I can add one

@AbhiPrasad
Copy link
Member Author

One day I'll get these tests to pass 😠

@AbhiPrasad AbhiPrasad force-pushed the abhi-void-transport branch 3 times, most recently from 7159e34 to 9c1518f Compare February 27, 2024 20:48
@AbhiPrasad AbhiPrasad force-pushed the abhi-void-transport branch from fa28a1c to 3aed07c Compare March 4, 2024 17:42
@AbhiPrasad AbhiPrasad merged commit 166bfc9 into develop Mar 4, 2024
@AbhiPrasad AbhiPrasad deleted the abhi-void-transport branch March 4, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timfish timfish timfish approved these changes

@mydea mydea mydea approved these changes

@Lms24 Lms24 Lms24 approved these changes

@stephanie-anderson stephanie-anderson Awaiting requested review from stephanie-anderson stephanie-anderson was automatically assigned from getsentry/team-web-sdk-frontend

@lforst lforst Awaiting requested review from lforst lforst was automatically assigned from getsentry/team-web-sdk-frontend

Assignees

@AbhiPrasad AbhiPrasad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AbhiPrasad @lforst @timfish @mydea @Lms24