Skip to content

Replay: Events tagged with replay_id before sampling decision  #8055

Closed
@bruno-garcia

Description

@bruno-garcia

@billyvg spotted that:

For on error sampling, we moved sampling decision from the beginning of the process, to right before we flush the replay, but some of the tagging logic was not updated to reflect this. When we get an error (for on error sampling), we:

  • always tag the error event with the replay id
  • send event
  • add error id to replay context
  • SAMPLE ROLL
  • flush

So if it's unsampled, we will have incorrectly tagged the event and replay

Metadata

Metadata

Assignees

No one assigned

    Labels

    Package: replayIssues related to the Sentry Replay SDK

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions