Wrong transaction name for angular route event

[de-don]

Is there an existing issue for this?

• I have checked for existing issues https://github.com/getsentry/sentry-javascript/issues
• I have reviewed the documentation https://docs.sentry.io/
• I am using the latest SDK release https://github.com/getsentry/sentry-javascript/releases

How do you use Sentry?

Self-hosted/on-premise

Which SDK are you using? If you use the CDN bundles, please specify the exact bundle (e.g. bundle.tracing.min.js) in your SDK setup.

@sentry/angular

SDK Version

7.46.0

Framework Version

Angular 15.1.5

Link to Sentry event

No response

SDK Setup

// Integrations

        new BrowserTracing({
          tracePropagationTargets: config.browserTracing.targets,
          routingInstrumentation: Sentry.routingInstrumentation,
        }),

// Providers

        {
          provide: Sentry.TraceService,
          deps: [Router],
        },
        {
          provide: APP_INITIALIZER,
          useFactory: () => () => void 0,
          deps: [Sentry.TraceService],
          multi: true,
        },

Steps to Reproduce

1. Configure application with nested routes with parameters
2. Configure BrowserTracing
3. Check sentry logs

In my app I have urls like:

/:lang/user/:id/details
/en/user/123/details

Expected Result

When user visit /en/user/123/details, transaction name should be /en/user/123/details

Actual Result

When user visit /en/user/123/details, transaction name is /:lang

The ptoblem that my app has routes with empty path, so in function getParameterizedRouteFromSnapshot this routes stops the recursion.

[Lms24]

Hi @de-don thanks for writing in!

Looks like there's something wrong with our current router instrumentation then. Thanks for opening a PR, I'll take a look soon.

Expected Result
When user visit /en/user/123/details, transaction name should be /en/user/123/details

This we cannot provide out of the box because we have to return the parameterized route as a transaction name. Hence, I'd expect that /en/user/123/details becomes /:lang/user/:id/details. I'd also argue, that this is in the best interest of most of our users because a parameterized transaction groups individual events, meaning you won't end up with different transactions for the same route if multiple user ids visit this route.

If you really want to have unparameterized route transaction names, you can manually override the name in the beforeNavigate hook of the BrowserTracing init options.