Linked errors don't contain code in stack traces since 6.18.x

[pepakriz]

Is there an existing issue for this?

• I have checked for existing issues https://github.com/getsentry/sentry-javascript/issues
• I have reviewed the documentation https://docs.sentry.io/
• I am using the latest SDK release https://github.com/getsentry/sentry-javascript/releases

How do you use Sentry?

Sentry Saas (sentry.io)

Which package are you using?

@sentry/node

SDK Version

6.18.2

Framework Version

No response

Link to Sentry event

https://sentry.io/organizations/qerko/issues/3110289269/?environment=local&project=5190601&query=is%3Aunresolved&statsPeriod=14d

Steps to Reproduce

1. use 6.17.9
2. there is a code stack trace for linked errors (see https://sentry.io/organizations/qerko/issues/3110381659/?environment=local&project=5190601&query=is%3Aunresolved&statsPeriod=14d)
3. use 6.18.x
4. there is no code stack trace for linked errors. Just for the main error. (see https://sentry.io/organizations/qerko/issues/3110289269/?environment=local&project=5190601&query=is%3Aunresolved&statsPeriod=14d)

Expected Result

Code exists in linked error stack trace

Actual Result

There is no stack trace for linked errors

[AbhiPrasad]

We merged event.exception.values, which should keep the frames ok.

sentry-javascript/packages/node/src/integrations/linkederrors.ts

Line 66 in 4eadcaf

event.exception.values = [...linkedErrors, ...event.exception.values];

@timfish mind taking a look when you get some time?

[pepakriz]

This issue is resolved partially. When I use default integration settings, it works correctly. But when I try to change LinkedError configuration by integrations field, the issue is back. My suspicion is that my custom configuration brokes the order of integrations.

integrations: [
        new Integrations.LinkedErrors({
            key: 'previousError',
        }),
    ],

My suspicion is that my custom configuration somehow brokes the order of integrations. When I try to configure LinkedErrors by copy&pasting the whole defaultIntegrations config and making some changes, it works.

    defaultIntegrations: [
        new CoreIntegrations.InboundFilters(),
        new CoreIntegrations.FunctionToString(),
        // Native Wrappers
        new Integrations.Console(),
        new Integrations.Http(),
        // Global Handlers
        new Integrations.OnUncaughtException(),
        new Integrations.OnUnhandledRejection(),
        // Misc
        new Integrations.LinkedErrors({
            key: 'previousError', // my modification
        }),
        // ContextLines must come after LinkedErrors so that context is added to linked errors
        new Integrations.ContextLines(),
    ],

[AbhiPrasad]

Ah yeah, I guess as per my fated comment: #4734 (review), we should figure this out now.

perhaps we have no choice but to extract this back from an integration into the client stack trace processing logic? @timfish what do you think?

[timfish]

We could always add a few lines of code after here that ensure that the ContextLines integration is always last.

sentry-javascript/packages/node/src/sdk.ts

Lines 82 to 93 in ac0bc26

	export function init(options: NodeOptions = {}): void {
	const carrier = getMainCarrier();
	const autoloadedIntegrations = carrier.__SENTRY__?.integrations || [];
	options.defaultIntegrations =
	options.defaultIntegrations === false
	? []
	: [
	...(Array.isArray(options.defaultIntegrations) ? options.defaultIntegrations : defaultIntegrations),
	...autoloadedIntegrations,
	];

[timfish]

Another possibly better alternative would be...

In the LinkedErrors integration, check for the inclusion of the ContextLines integration via getIntegration() and add the context to the linked errors at that point.

[AbhiPrasad]

Let's update node/src/sdk.ts for now - it's the fastest solution to unblock.

[timfish]

It looks like it's not possible to do it cleanly/simply from node/src/sdk.ts because @sentry/core favours/spreads user supplied integrations over the default integrations 😬

sentry-javascript/packages/core/src/integration.ts

Lines 33 to 36 in 2b5be64

	integrations = [
	...integrations.filter(integrations =>
	userIntegrations.every(userIntegration => userIntegration.name !== integrations.name),
	),

It looks like @sentry/core already does some ordering for the Debug integration:

sentry-javascript/packages/core/src/integration.ts

Lines 45 to 50 in 2b5be64

	// Make sure that if present, `Debug` integration will always run last
	const integrationsNames = integrations.map(i => i.name);
	const alwaysLastToRun = 'Debug';
	if (integrationsNames.indexOf(alwaysLastToRun) !== -1) {
	integrations.push(...integrations.splice(integrationsNames.indexOf(alwaysLastToRun), 1));
	}