Skip to content

Stop setting event.request in Browser SDKs #15845

Open
@mydea

Description

@mydea

Description

Today, we set data about the current page on event.request in the Browser SDK. This is done by the HttpContext integration:

 // if none of the information we want exists, don't bother
      if (!WINDOW.navigator && !WINDOW.location && !WINDOW.document) {
        return;
      }

      // grab as much info as exists and add it to the event
      const url = event.request?.url || getLocationHref();
      const { referrer } = WINDOW.document || {};
      const { userAgent } = WINDOW.navigator || {};

      const headers = {
        ...event.request?.headers,
        ...(referrer && { Referer: referrer }),
        ...(userAgent && { 'User-Agent': userAgent }),
      };
      const request = {
        ...event.request,
        ...(url && { url }),
        headers,
      };

      event.request = request;

In product, we show this as "HTTP Request Information" which is pretty confusing. We should stop setting this for browser SDKs, and instead set this information in a different place (e.g. in a page context, TBD).

We can then think about instead using this place to store outgoing-request information for failed fetch calls.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions