Skip to content

ref(crons): Simplify example, add async note #9574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 3, 2024

Conversation

sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Mar 28, 2024

Pre-merge checklist

If you work at Sentry, you're able to merge your own PR without review, but please don't unless there's a good reason.

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs
  • PR was reviewed and approved by a member of the Sentry docs team

Description of changes

We'll be adding support for monitoring async functions in getsentry/sentry-python#2912:

  • added a note about the minimal version to the main Python crons page
  • simplified the examples on the crons page into more digestible code snippets
  • added a note to the crons troubleshooting page as well since we had customers asking about this

Direct link to preview:

Extra resources

Copy link

vercel bot commented Mar 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 2, 2024 11:29am

Copy link

codecov bot commented Mar 28, 2024

Bundle Report

Changes will decrease total bundle size by 9 bytes ⬇️

Bundle name Size Change
sentry-docs-server 6.11MB 0 bytes
sentry-docs-edge-server 618.05kB 3 bytes ⬇️
sentry-docs-client 5.52MB 6 bytes ⬇️

@sentrivana sentrivana marked this pull request as ready for review March 28, 2024 11:28
Copy link
Contributor

@vivianyentran vivianyentran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

sentrivana and others added 2 commits April 2, 2024 10:10
Co-authored-by: vivianyentran <20403606+vivianyentran@users.noreply.github.com>
@sentrivana
Copy link
Contributor Author

sentrivana commented Apr 2, 2024

Will merge as soon as the release is out -- likely sometime this week (EDIT: actually today)

@sentrivana sentrivana enabled auto-merge (squash) April 2, 2024 11:03
@sentrivana sentrivana disabled auto-merge April 2, 2024 11:12
@sentrivana sentrivana merged commit aaec02b into master Apr 3, 2024
@sentrivana sentrivana deleted the ivana/python-async-crons branch April 3, 2024 08:56
@github-actions github-actions bot locked and limited conversation to collaborators Apr 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants