Skip to content

BUG: reflect changes in bool(geom) in shapely 1.7 #1244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 20, 2020
Merged

BUG: reflect changes in bool(geom) in shapely 1.7 #1244

merged 3 commits into from
Jan 20, 2020

Conversation

martinfleis
Copy link
Member

Shapely have changed the behaviour of boolean representation of empty geometries (shapely/shapely#812) which broke our _binary_geo. I have made the condition used there more explicit to avoid the issue.

@martinfleis martinfleis mentioned this pull request Jan 6, 2020
Merged
@martinfleis
Copy link
Member Author

Alright. In the meantime, there was another change on pandas master causing new fails. As there are like four pages of commits to pandas master in last 6 days (since this passed), I am struggling a bit to find what caused the issue.

@martinfleis
Copy link
Member Author

Got it. pandas-dev/pandas#30308 Pandas added new tests for ExtensionArray for which our GeometryArray was not ready :). This will require some changes in GeometryArray. I'll open separate issue for that.

This was referenced Jan 6, 2020
Closed
Merged
@jorisvandenbossche
Copy link
Member

Can you merge master now I merged the other PR? That should then give green tests again.

@martinfleis
Copy link
Member Author

Green again. If you don't have any further comments we can merge and I'll update those red PRs to make them finally green.

@jorisvandenbossche jorisvandenbossche merged commit dcda96f into geopandas:master Jan 20, 2020
@jorisvandenbossche
Copy link
Member

Thanks!

I am personally not fully convinced this was a good change in shapely, but will comment about that there.

@martinfleis martinfleis deleted the shapely_17 branch January 20, 2020 15:26
@jorisvandenbossche jorisvandenbossche mentioned this pull request Jan 28, 2020
Closed
jorisvandenbossche pushed a commit to jorisvandenbossche/geopandas that referenced this pull request Feb 6, 2020
@martinfleis @jorisvandenbossche
BUG: reflect changes in bool(geom) in shapely 1.7 (geopandas#1244)
daa53ce 
(cherry picked from commit dcda96f)
jorisvandenbossche pushed a commit that referenced this pull request Feb 6, 2020
@martinfleis @jorisvandenbossche
BUG: reflect changes in bool(geom) in shapely 1.7 (#1244)
7ac457f 
(cherry picked from commit dcda96f)
lwasser pushed a commit to lwasser/geopandas that referenced this pull request Apr 8, 2020
@martinfleis
BUG: reflect changes in bool(geom) in shapely 1.7 (geopandas#1244)
c1bee57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorisvandenbossche jorisvandenbossche jorisvandenbossche approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martinfleis @jorisvandenbossche