Skip to content

Enable PHP 8.0 support (2) #1104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 21, 2020
Merged

Enable PHP 8.0 support (2) #1104

merged 1 commit into from
Dec 21, 2020

Conversation

jbelien
Copy link
Member

@jbelien jbelien commented Dec 21, 2020 •
edited
Loading

Following #1103 !

  • Upgrade php-http/curl-client for every provider
  • Upgrade PHPUnit config

This is the last step to complete full PHP 8.0 support.

@jbelien jbelien linked an issue Dec 21, 2020 that may be closed by this pull request
Support for PHP 8.0 #1093
Closed
@jbelien jbelien marked this pull request as ready for review December 21, 2020 13:25
@jbelien jbelien requested review from atymic and Nyholm December 21, 2020 13:25
Nyholm
Nyholm approved these changes Dec 21, 2020
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool cool

Great work!

@jbelien jbelien merged commit 5d4923d into master Dec 21, 2020
@jbelien jbelien deleted the php8 branch December 21, 2020 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nyholm Nyholm Nyholm approved these changes

@atymic atymic Awaiting requested review from atymic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for PHP 8.0
2 participants
@jbelien @Nyholm