Skip to content

feat: use eslint-compat-utils #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 12, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/rich-goats-notice.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"eslint-plugin-vue-scoped-css": minor
---

feat: use eslint-compat-utils
49 changes: 49 additions & 0 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,55 @@ module.exports = {
"@typescript-eslint/ban-ts-ignore": "off",
"eslint-comments/no-unused-disable": "error",
"@typescript-eslint/no-non-null-assertion": "off",
// Repo rule
"@typescript-eslint/no-restricted-imports": [
"error",
{
patterns: [
{
group: ["/regexpp", "/regexpp/*"],
message: "Please use `@eslint-community/regexpp` instead.",
},
{
group: ["/eslint-utils", "/eslint-utils/*"],
message: "Please use `@eslint-community/eslint-utils` instead.",
},
],
},
],
"no-restricted-properties": [
"error",
{
object: "context",
property: "getSourceCode",
message: "Use src/utils/compat.ts",
},
{
object: "context",
property: "getFilename",
message: "Use src/utils/compat.ts",
},
{
object: "context",
property: "getPhysicalFilename",
message: "Use src/utils/compat.ts",
},
{
object: "context",
property: "getCwd",
message: "Use src/utils/compat.ts",
},
{
object: "context",
property: "getScope",
message: "Use src/utils/compat.ts",
},
{
object: "context",
property: "parserServices",
message: "Use src/utils/compat.ts",
},
],
},
overrides: [
{
Expand Down
31 changes: 31 additions & 0 deletions .github/workflows/format.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
name: 👔 Format

on:
workflow_dispatch: null

jobs:
format:
runs-on: ubuntu-latest

steps:
- name: Checkout repo
uses: actions/checkout@v4
- name: Setup node
uses: actions/setup-node@v4
- name: Install deps
run: npm install
- name: Format
run: npm run eslint-fix
- name: Commit
run: |
git config --local user.email "github-actions[bot]@users.noreply.github.com"
git config --local user.name "github-actions[bot]"

git add .
if [ -z "$(git status --porcelain)" ]; then
echo "no formatting changed"
exit 0
fi
git commit -m "chore: format"
git push
echo "pushed formatting changes https://github.com/$GITHUB_REPOSITORY/commit/$(git rev-parse HEAD)"
1 change: 0 additions & 1 deletion docs/.vuepress/components/demo/stylelint.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ module.exports = {
extends: ["stylelint-config-standard"],
rules: {
"no-descending-specificity": null,
indentation: null,
"selector-max-empty-lines": null,
"selector-type-no-unknown": null,
"block-no-empty": null,
Expand Down
1 change: 0 additions & 1 deletion docs/.vuepress/components/stylelint.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,5 @@ module.exports = {
extends: ["stylelint-config-standard", "stylelint-config-recommended-vue"],
rules: {
"no-descending-specificity": null,
indentation: null,
},
};
4 changes: 3 additions & 1 deletion lib/rules/enforce-style-type.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import {
isValidStyleContext,
getCommentDirectivesReporter,
} from "../styles/context";
import { getSourceCode } from "../utils/compat";

const styleTypesAttrs = ["scoped", "module"] as const;
type StyleTypes = "plain" | (typeof styleTypesAttrs)[number];
Expand Down Expand Up @@ -64,8 +65,9 @@ export = {
}

const reporter = getCommentDirectivesReporter(context);
const sourceCode = getSourceCode(context);
const tokenStore =
context.parserServices.getTemplateBodyTokenStore?.() as TokenStore;
sourceCode.parserServices.getTemplateBodyTokenStore?.() as TokenStore;
const { options } = context;

const allows: AllowsOption = options[0]?.allows ?? ["scoped"];
Expand Down
3 changes: 2 additions & 1 deletion lib/rules/no-deprecated-deep-combinator.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import {
import type { VCSSSelectorCombinator } from "../styles/ast";
import type { RuleContext, Range, RuleListener } from "../types";
import { isDeepCombinator } from "../styles/utils/selectors";
import { getSourceCode } from "../utils/compat";

export = {
meta: {
Expand Down Expand Up @@ -45,7 +46,7 @@ export = {
value: node.value.trim(),
},
fix(fixer) {
const sourceCodeText = context.getSourceCode().text;
const sourceCodeText = getSourceCode(context).text;
const range = [...node.range] as Range;
let newText = "::v-deep";
if (sourceCodeText[range[0] - 1]?.trim()) {
Expand Down
3 changes: 2 additions & 1 deletion lib/rules/no-unused-keyframes.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import {
getCommentDirectivesReporter,
} from "../styles/context";
import { isValidStyleContext } from "../styles/context/style";
import { getSourceCode } from "../utils/compat";

export = {
meta: {
Expand Down Expand Up @@ -42,7 +43,7 @@ export = {
return {};
}
const reporter = getCommentDirectivesReporter(context);
const sourceCode = context.getSourceCode();
const sourceCode = getSourceCode(context);

/**
* Reports the given node
Expand Down
4 changes: 3 additions & 1 deletion lib/rules/require-scoped.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import {
isValidStyleContext,
getCommentDirectivesReporter,
} from "../styles/context";
import { getSourceCode } from "../utils/compat";

export = {
meta: {
Expand Down Expand Up @@ -40,8 +41,9 @@ export = {
return {};
}
const reporter = getCommentDirectivesReporter(context);
const sourceCode = getSourceCode(context);
const tokenStore =
context.parserServices.getTemplateBodyTokenStore?.() as TokenStore;
sourceCode.parserServices.getTemplateBodyTokenStore?.() as TokenStore;

/**
* Reports the given node.
Expand Down
4 changes: 2 additions & 2 deletions lib/rules/require-v-deep-argument.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import {
isVCSSDeclarationProperty,
isVCSSComment,
} from "../styles/utils/css-nodes";
import { getSourceCode } from "../utils/compat";

export = {
meta: {
Expand Down Expand Up @@ -90,8 +91,7 @@ export = {
nextNode.range[0],
];
if (
context
.getSourceCode()
getSourceCode(context)
.text.slice(...betweenRange)
.trim()
) {
Expand Down
3 changes: 2 additions & 1 deletion lib/rules/v-deep-pseudo-style.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import {
isVDeepPseudo,
isPseudoEmptyArguments,
} from "../styles/utils/selectors";
import { getSourceCode } from "../utils/compat";

export = {
meta: {
Expand Down Expand Up @@ -50,7 +51,7 @@ export = {
loc: node.loc,
messageId: expected === ":deep" ? "expectedDeep" : "expectedVDeep",
fix(fixer) {
const nodeText = context.getSourceCode().text.slice(...node.range);
const nodeText = getSourceCode(context).text.slice(...node.range);
return fixer.replaceTextRange(
node.range,
nodeText.replace(
Expand Down
3 changes: 2 additions & 1 deletion lib/rules/v-global-pseudo-style.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import {
isVGlobalPseudo,
isPseudoEmptyArguments,
} from "../styles/utils/selectors";
import { getSourceCode } from "../utils/compat";

export = {
meta: {
Expand Down Expand Up @@ -53,7 +54,7 @@ export = {
messageId:
expected === ":global" ? "expectedGlobal" : "expectedVGlobal",
fix(fixer) {
const nodeText = context.getSourceCode().text.slice(...node.range);
const nodeText = getSourceCode(context).text.slice(...node.range);
return fixer.replaceTextRange(
node.range,
nodeText.replace(
Expand Down
3 changes: 2 additions & 1 deletion lib/rules/v-slotted-pseudo-style.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import {
isVSlottedPseudo,
isPseudoEmptyArguments,
} from "../styles/utils/selectors";
import { getSourceCode } from "../utils/compat";

export = {
meta: {
Expand Down Expand Up @@ -53,7 +54,7 @@ export = {
messageId:
expected === ":slotted" ? "expectedSlotted" : "expectedVSlotted",
fix(fixer) {
const nodeText = context.getSourceCode().text.slice(...node.range);
const nodeText = getSourceCode(context).text.slice(...node.range);
return fixer.replaceTextRange(
node.range,
nodeText.replace(
Expand Down
3 changes: 2 additions & 1 deletion lib/styles/context/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import {
VueComponentContext,
createVueComponentContext,
} from "./vue-components";
import { getSourceCode } from "../../utils/compat";

type CacheValue = {
styles?: StyleContext[];
Expand All @@ -32,7 +33,7 @@ const CACHE = new WeakMap<AST.ESLintProgram, CacheValue>();
* Gets the cache.
*/
function getCache(context: RuleContext): CacheValue {
const sourceCode = context.getSourceCode();
const sourceCode = getSourceCode(context);
const { ast } = sourceCode;
if (CACHE.has(ast)) {
return CACHE.get(ast) as CacheValue;
Expand Down
16 changes: 9 additions & 7 deletions lib/styles/context/style/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import type {
} from "../../../types";
import type { VCSSStyleSheet, VCSSNode, VCSSSelectorNode } from "../../ast";
import { isVCSSContainerNode, hasSelectorNodes } from "../../utils/css-nodes";
import { getSourceCode } from "../../../utils/compat";

/**
* Check whether the program has invalid EOF or not.
Expand All @@ -18,16 +19,17 @@ function getInvalidEOFError(
inDocumentFragment: boolean;
error: AST.ParseError;
} | null {
const node = context.getSourceCode().ast;
const node = getSourceCode(context).ast;
const body = node.templateBody;
let errors = body?.errors;
let inDocumentFragment = false;
if (errors == null) {
const sourceCode = getSourceCode(context);
/* istanbul ignore if */
if (!context.parserServices.getDocumentFragment) {
if (!sourceCode.parserServices.getDocumentFragment) {
return null;
}
const df = context.parserServices.getDocumentFragment();
const df = sourceCode.parserServices.getDocumentFragment();
inDocumentFragment = true;
errors = df?.errors;
/* istanbul ignore if */
Expand Down Expand Up @@ -62,11 +64,11 @@ function getInvalidEOFError(
*/
function getStyleElements(context: RuleContext): AST.VElement[] {
let document: AST.VDocumentFragment | null = null;
if (context.parserServices.getDocumentFragment) {
const sourceCode = getSourceCode(context);
if (sourceCode.parserServices.getDocumentFragment) {
// vue-eslint-parser v7.0.0
document = context.parserServices.getDocumentFragment();
document = sourceCode.parserServices.getDocumentFragment();
} else {
const sourceCode = context.getSourceCode();
const { ast } = sourceCode;
const templateBody = ast.templateBody as AST.ESLintProgram | undefined;
/* istanbul ignore if */
Expand Down Expand Up @@ -189,7 +191,7 @@ export class StyleContextImpl {
public readonly cssNode: VCSSStyleSheet | null;

public constructor(style: AST.VElement, context: RuleContext) {
const sourceCode = context.getSourceCode();
const sourceCode = getSourceCode(context);
this.styleElement = style;
this.sourceCode = sourceCode;

Expand Down
3 changes: 2 additions & 1 deletion lib/styles/context/vue-components/find-vue.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { AST } from "vue-eslint-parser";
import type { ASTNode, RuleContext } from "../../../types";
import { unwrapTypesExpression } from "../../utils/nodes";
import { getSourceCode } from "../../../utils/compat";

const traverseNodes = AST.traverseNodes;

Expand Down Expand Up @@ -73,7 +74,7 @@ function findVueComponent(
return cached.component;
}

const sourceCode = context.getSourceCode();
const sourceCode = getSourceCode(context);
const componentComments = sourceCode
.getAllComments()
.filter((comment) => comment.value.includes("@vue/component"));
Expand Down
5 changes: 3 additions & 2 deletions lib/styles/context/vue-components/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import findVueComponent from "./find-vue";
import type { RuleContext, ASTNode, AST } from "../../../types";
import type { Template } from "../../template";
import { isDefined } from "../../../utils/utils";
import { getSourceCode } from "../../../utils/compat";

const traverseNodes = vueAST.traverseNodes;

Expand Down Expand Up @@ -288,7 +289,7 @@ function getClassesOperatedByClassList(
): (AST.ESLintExpression | AST.ESLintSpreadElement)[] {
const results: (AST.ESLintExpression | AST.ESLintSpreadElement)[] = [];
traverseNodes(vueNode, {
visitorKeys: context.getSourceCode().visitorKeys,
visitorKeys: getSourceCode(context).visitorKeys,
enterNode(node) {
if (
node.type !== "CallExpression" ||
Expand Down Expand Up @@ -351,7 +352,7 @@ function getReturnStatements(
| AST.ESLintFunctionDeclaration
)[] = [];
traverseNodes(body, {
visitorKeys: context.getSourceCode().visitorKeys,
visitorKeys: getSourceCode(context).visitorKeys,
enterNode(node) {
if (skipNodes.length) {
return;
Expand Down
1 change: 1 addition & 0 deletions lib/styles/selectors/query/attribute-tracker.ts
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ export function getAttributeValueNodes(
// empty or syntax error
continue;
}
if (expression.type === "VGenericExpression") continue;
const expressions = getReferenceExpressions(expression, context);
if (!expressions) {
// Expressions not found.
Expand Down
3 changes: 2 additions & 1 deletion lib/styles/selectors/query/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ import { isVElement, isTransitionElement } from "../../../utils/templates";
import { isValidStyleContext } from "../../context/style";
import type { ReferenceExpressions } from "./reference-expression";
import { getReferenceExpressions } from "./reference-expression";
import { getSourceCode } from "../../../utils/compat";

const TRANSITION_CLASS_BASES = [
"enter",
Expand Down Expand Up @@ -130,7 +131,7 @@ class VueDocumentQueryContext extends QueryContext {

public constructor(context: RuleContext, options: ParsedQueryOptions) {
super();
const sourceCode = context.getSourceCode();
const sourceCode = getSourceCode(context);
const { ast } = sourceCode;
this.elements = ast.templateBody
? [...genDescendantElements([ast.templateBody])]
Expand Down
Loading