Remove deprecated createJSModules @Override #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should you get rid of the entire method, not just the override directive? |
|
If you remove the entire method instead of the Override , backwards compatibility is lost. |
|
Just a side note, the package.json still needs to be updated but a workaround would be loading the package from git opposed to the NPM repository |
|
@auser could you please push the npm version? And maybe make sure package.json and npm version match? |
mribbons
added a commit
to mribbons/react-native-oauth
that referenced
this pull request
Mar 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking changes in React Native 0.47
facebook/react-native@ce6fb33