Skip to content

Adding missing user info mapping to getUserMap (Android) #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 26, 2016
Merged

Adding missing user info mapping to getUserMap (Android) #85

merged 1 commit into from
Oct 26, 2016

Conversation

pedro-ribeiro
Copy link
Contributor

Notes:

  • from what I can tell from the documentation, user.getToken() does not affect user data besides the token
  • made name optional since, like photoUrl, firebase does not require it
  • changed provider key used in getUserMap() to providerId as used in the other mappings
  • missing equivalent implementation for iOS

@auser auser merged commit 07aecfb into fullstackreact:master Oct 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pedro-ribeiro @auser