Skip to content

[v3] Support for ref.once('child_added') #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 17, 2017

Conversation

FrankSalad
Copy link

No description provided.

Copy link
Contributor

@auser auser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, can we add this to the Android side too?

@auser auser merged commit 5199f6f into fullstackreact:v3 Jan 17, 2017
@chrisbianca
Copy link
Contributor

This has completely broken Android database functionality due to the changes that have been made to the Javascript and the data structure it now expects from the native side.

Any breaking changes to the native interface should really be implemented on both iOS and Android simultaneously.

@auser I'm not sure what the best course of action is here. Whether to revert the changes or wait for somebody to fix Android and properly test that nothing else has broken? Unfortunately I just can't spare the time at the moment to look myself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants