Skip to content

Add command to scaffold, download input and read challenge for current date #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 9, 2023
Merged

Conversation

tomvaneyck
Copy link
Contributor

This pull request combines the scaffold, download and read commands into one, auto selecting the current date or accepting an optional day.

Command:

cargo today [<day>]

@tomvaneyck tomvaneyck marked this pull request as ready for review December 4, 2023 12:06
@tomvaneyck
Copy link
Contributor Author

It seems like I had the same idea as someone else a moment ago (#42) 😃. I leave the choice on the final implementation to you.

@fspoettel
Copy link
Owner

Hey, thanks for the PR! I like the idea of a today command. I'll review this PR in detail when I have some time in the next couple of days.

I'm not 100% sure if today should have the day flag or if we rather want to split it into cargo scaffold [-d, --download] <arbitrary_day> and cargo today (magical shorthand usable in december).

@tomvaneyck
Copy link
Contributor Author

I think I addressed all comments, except for the one about using chrono. However, using that crate seems like the only way to get the current day of the month.

@fspoettel
Copy link
Owner

What we can definitely do is put chrono behind a feature flag and add it to the today alias.

@fspoettel fspoettel merged commit f8a1368 into fspoettel:main Dec 9, 2023
@fspoettel
Copy link
Owner

Thank you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants