Skip to content

New GNU Fortran intrinsics. #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 17, 2019
Merged

New GNU Fortran intrinsics. #122

merged 4 commits into from
Mar 17, 2019

Conversation

pedro-ricardo
Copy link
Collaborator

@pedro-ricardo pedro-ricardo commented Mar 16, 2019

Added missing intrinsic functions from newest GFortran documentation at Intrinsic-Procedures.
Also Fix issue #113 by adding ELSE and STOP as keywords

  • Add intrinsics on js file
  • Add intrinsic json files

@pedro-ricardo pedro-ricardo mentioned this pull request Mar 16, 2019
7 tasks
@pedro-ricardo pedro-ricardo requested a review from krvajal March 16, 2019 16:01
@krvajal
Copy link
Collaborator

krvajal commented Mar 16, 2019

We should add the new intrinsics here as well https://github.com/krvajal/vscode-fortran-support/blob/master/src/docs/

@pedro-ricardo
Copy link
Collaborator Author

I'll add those soon, thank you.

@pedro-ricardo
Copy link
Collaborator Author

Done that tedious work of copying the documentation to json files. 👍

@pedro-ricardo
Copy link
Collaborator Author

@krvajal Is that a reason why our intrinsic documentation files have 3 or 4 copies of the same structure?
Like the first one ABORT.json and all others I've oppended, the structure of the file should resemble the below:

{
"keyword":"",
"docstr":""
}

But they are in one line and repeated 4 times or more

{"keyword":"","docstr":""}{"keyword":"","docstr":""}{"keyword":"","docstr":""}{"keyword":"","docstr":""}

If you look for the closing bracket and enter return after each one this is what you'll get
abort

Should we consider this a bug?

@krvajal
Copy link
Collaborator

krvajal commented Mar 16, 2019

Should we consider this a bug?

Yes, it is indeed a bug as it is not valid JSON.

@pedro-ricardo
Copy link
Collaborator Author

Ok done. Used VSCode smart search and replace to remove duplicates and then indent the files better.

Copy link
Collaborator

@krvajal krvajal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work

@pedro-ricardo pedro-ricardo merged commit a2fb155 into release/2.1.0 Mar 17, 2019
@pedro-ricardo pedro-ricardo deleted the hotfix/intrinsics branch March 17, 2019 21:05
krvajal pushed a commit that referenced this pull request Mar 26, 2019
### Check List
- [x] Merge #120 suggestion of #105
- [x] Merge #112 for fix on issue #110
- [x] Merge #117 for fix on issue #115
- [x] Merge #118 for fix on issue #116
- [x] Merge #122 for fix on issue #113
- [x] Update CHANGELOG.md
- [x] Update Package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants