Skip to content

updates to correct linter slashes for mixed platform projects #1016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

emanspeaks
Copy link
Contributor

Closes #1015

@gnikit gnikit force-pushed the 1015-linter-path-fixes branch from 57961aa to 256f836 Compare December 10, 2023 13:51
Copy link

codecov bot commented Dec 10, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (c7dd7a0) 83.64% compared to head (d234716) 83.60%.

Files Patch % Lines
src/lint/provider.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1016      +/-   ##
==========================================
- Coverage   83.64%   83.60%   -0.04%     
==========================================
  Files          12       12              
  Lines        2311     2312       +1     
  Branches      205      205              
==========================================
  Hits         1933     1933              
- Misses        373      374       +1     
  Partials        5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gnikit
Copy link
Member

gnikit commented Dec 11, 2023

Thanks for this @emanspeaks I will merge it probably later today, I just need to finish some other maintenance and bug fixing for the extension. (we can ignore the drop in coverage since there is no CI for windows).

@gnikit gnikit force-pushed the 1015-linter-path-fixes branch from 256f836 to d234716 Compare December 11, 2023 16:47
Copy link
Member

@gnikit gnikit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix and nice catch (for both the regex and the globPaths)

@gnikit gnikit merged commit 8b5096f into fortran-lang:main Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Linter path issues on Windows
2 participants