Skip to content

Add [install] section to fpm.toml #903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 138 commits into from

Conversation

moriglia
Copy link
Contributor

@moriglia moriglia commented Dec 9, 2024

This commit allows for installation of the stdlib, instructing fpm to install (if the prefix is not modified):

  • libstdlib.a file --> ~/.local/lib/
  • .[s]mod files --> ~/.local/include/

Example:
fpm install --compiler=gfortran-11 --profile release

Resolves #782

jvdp1 and others added 30 commits September 16, 2021 18:17
@moriglia moriglia changed the title Add [install] section to fpm.toml Add [install] section to fpm.toml Dec 9, 2024
Copy link
Member

@perazz perazz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @moriglia, LGTM. Definitely a good idea, since this is a library. Let's wait for another review and comments.

Copy link
Member

@jvdp1 jvdp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @moriglia . It makes sense to me. It might be good to mention this new behaviour in the README.

@jvdp1
Copy link
Member

jvdp1 commented Dec 9, 2024

cc: @jalvesz

@jalvesz
Copy link
Contributor

jalvesz commented Dec 10, 2024

LGTM @moriglia thanks for this contribution!

Co-authored-by: Jeremie Vandenplas <jeremie.vandenplas@gmail.com>
@moriglia
Copy link
Contributor Author

Thank you all for your positive feedback!

It might be good to mention this new behaviour in the README.

Sure, I think I should open a separate PR though, since the README is present only on the master branch. Unless you want it to appear also on the stdlib-fpm branch. In which branch do you think the README edit would be more appropriate?

@jalvesz
Copy link
Contributor

jalvesz commented Dec 10, 2024

The stdlib-fpm branch is a subproduct of the automatic github CI. All contributions should be made through the master branch. You can add the info either around here https://github.com/fortran-lang/stdlib/blob/master/README.md#build-with-fortran-langfpm or here https://github.com/fortran-lang/stdlib/blob/master/README.md#using-stdlib-with-fpm. Also, all fpm actions are possible with the master branch following the fypp preprocessing as discribed in the first link. So if one uses the master branch, installation through fpm is possible.

@perazz
Copy link
Member

perazz commented Dec 10, 2024

@jalvesz is right, thank you for noticing it. These changes should be moved to the main branch fpm.toml

@moriglia
Copy link
Contributor Author

The stdlib-fpm branch is a subproduct of the automatic github CI. All contributions should be made through the master branch. You can add the info either around here https://github.com/fortran-lang/stdlib/blob/master/README.md#build-with-fortran-langfpm or here https://github.com/fortran-lang/stdlib/blob/master/README.md#using-stdlib-with-fpm. Also, all fpm actions are possible with the master branch following the fypp preprocessing as discribed in the first link. So if one uses the master branch, installation through fpm is possible.

While reading the README to edit it, right before reading your message, I just realised that this PR is on the wrong branch.
I will revert to draft.

@moriglia moriglia marked this pull request as draft December 10, 2024 10:47
@moriglia moriglia changed the base branch from stdlib-fpm to master December 10, 2024 10:48
@moriglia moriglia closed this Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add library configuration to stdlib-fpm
10 participants