Reduce redundancy caused by optional arguments #528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
September 17, 2021 18:38
This commit replaces the if-else-block handling the optional prefix arguments. The colon which was previously appended, if the prefix argument was present, is only appended if the prefix argument contains any characters. Previously, prefix='' would end up getting extended to pref=': '.
The optional advance argument leads to a redundant call of read/write routines which can be deduplicated by making use of the optval-function.
The optval function replaces some nested if statemens and allows to remove the reverse_ variable which is a clone of the optional reverse variable.
By using the optval function only one write operation to the si variable is necessary.
The if-else-blocks in the moment_all functions couldn't be replaced with the optval function, because this would lead to poor performance. If the center variable is present, the calculation of the mean can be skipped, but the optval function prevents this optimisation.
Each routine using the optional 'back' argument could be shortend to a single line of code.
milancurcic
reviewed
Sep 17, 2021
milancurcic
approved these changes
Sep 17, 2021
jvdp1
reviewed
Sep 17, 2021
|
I'm cautious about this pull request, because I don't understand the performance implications of generally replacing |
awvwgk
added
refactoring
jvdp1
approved these changes
Sep 18, 2021
There was a problem hiding this comment.
Based on all discussions in this PR, and in #524, I approve this PR as it is currently. Thank you @Carltoffel .
|
Let's merge this tomorrow (Sep 21) if there are no objections. |
|
Thank you all for the respectful discussion about the performance. I've learned a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR I tried to reduce redundancy, primary by using the
optvalfunction.Some discoveries I made while working on this:
stdlib_iotheopenstatement is used with an optionaliostatargument. Sinceopenis an intrinsic function and not a routine, the optional argument cannot be directly passed, which leads to theopenstatement being defined twice. If it doesn't cause too much overhead I suggest to declare an extra variable which will always be passed to theiostatargument of theopenstatement. If the optionaliostatargument of theopenfunction is present, the result will then be written to the optional argument.simps_weightsfunction (stdlib_quadrature_simps.fypp) contains an nestedifstatement which could be rewritten asselect case ( optval(even, 0) ) .... I'm not sure if this would improve the code, but it would reduce theif-nesting by oneif.stdlib_stat_momenthas some functions which could be rewritten using theoptvalfunction, but as I mentioned in the commit message this is inefficient. Instead I introduced a new variable which de-duplicates the formular.min(max(...))construct which could be replaced withclip... I guess there are more of these, so maybe we should search and replace them where possible just like I did withpresent()andoptval()in this PR.closes #524