set the cmake build to out-of-source

[pdebuyl]

Change the github workflow for the cmake build.

I open the PR to trigger the workflow for the branch. The manual makefiles are not touched.

[certik]

I suggest we test both in tree and out of tree. The out of tree can be the default to test various compilers, etc. But on each platform we should have at least one test for in tree builds to ensure they still work.

…

On Sun, Dec 29, 2019, at 4:18 AM, Pierre de Buyl wrote: Change the github workflow for the cmake build. I open the PR to trigger the workflow for the branch. The manual makefiles are not touched. You can view, comment on, or merge this pull request online at: #50 Commit Summary * set the cmake build to out-of-source File Changes * *M* .github/workflows/main.yml <https://github.com/fortran-lang/stdlib/pull/50/files#diff-0> (6) Patch Links: * https://github.com/fortran-lang/stdlib/pull/50.patch * https://github.com/fortran-lang/stdlib/pull/50.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#50?email_source=notifications&email_token=AAAFAWCPMLOTFWZ2WDKIZ5LQ3CBPVA5CNFSM4KA22DJKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IDDA6JQ>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAFAWDZGU22X5XMLDIZCG3Q3CBPVANCNFSM4KA22DJA>.

[zbeekman]

@certik

I suggest we test both in tree and out of tree.

Out of curiosity, what is the motivation for maintaining in-tree builds?

Out-of-source builds are easier to cleanup after, and don't risk clobbering WIP changes. If we truly want to support both then I suppose we should test in source builds too, but I don't see a strong case for insisting on supporting both. In addition, out-of-source builds are more likely to fail from a misconfigured build system than in-source builds are.

I don't care that much about whether or not we want to support in source builds, but we don't want a combinatorial explosion of our build matrix if we can avoid it.

[zbeekman]

LGTM

[zbeekman]

Small fix: Delete stale comment please.

[zbeekman]

Suggested change

	run: cmake -Wdev -S . -B build # We should build out of source but loadtxt needs fixing
	run: cmake -Wdev -S . -B build

[zbeekman]

Actually, this comment should be deleted if the issue is fixed and being tested.

[pdebuyl]

I removed the comment. I didn't see that one could accept "suggested commits" online and did it via the CLI.

Regarding in-tree builds, I don't use them in my projects, I don't know how useful they are.

I proposed the cmake patch because I tested the build on my computer with the "idiomatic"

mkdir build
cd build
cmake ..
make

Maybe we need test users, with different coding habits.

[zbeekman]

It seems @certik is one such "test user" as he reported elsewhere that he typically does in-tree CMake builds... Given the goal of supporting Makefiles and CMake, I would advocate for in-source builds being "unsupported". Interested parties can still try to keep them working, but I don't want to explode our CI test matrix anymore than 3 oses and 3 versions of Fortran compilers, unless there is a really good reason.

[zbeekman]

LGTM

[jacobwilliams]

I don't think we should encourage in-source builds. :)

[certik]

This PR is ready to go in, so I am going to merge it.

[certik]

I submitted #55 for in-tree CI tests.