Skip to content

Update CI #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 21, 2021
Merged

Update CI #468

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b55e372
GitHub Actions now sets env var CI
scivision Jul 21, 2021
edd0efb
github actions recommends checkout@v2
scivision Jul 21, 2021
3bcd24d
CI: use contemporary CMake commands, remove deprecated parameters
scivision Jul 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions .github/workflows/CI.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ name: CI
on: [push, pull_request]

env:
CI: "ON" # We can detect this in the build system and other vendors implement it
CMAKE_BUILD_PARALLEL_LEVEL: "2" # 2 cores on each GHA VM, enable parallel builds
CTEST_OUTPUT_ON_FAILURE: "ON" # This way we don't need a flag to ctest
CTEST_PARALLEL_LEVEL: "2"
Expand All @@ -28,7 +27,7 @@ jobs:

steps:
- name: Checkout code
uses: actions/checkout@v1
uses: actions/checkout@v2

- name: Set up Python 3.x
uses: actions/setup-python@v1 # Use pip to install latest CMake, & FORD/Jin2For, etc.
Expand Down Expand Up @@ -67,15 +66,14 @@ jobs:
-S . -B build

- name: Build and compile
run: cmake --build build
run: cmake --build build --parallel

- name: catch build fail
run: cmake --build build --verbose --parallel 1
if: failure()

- name: test
run: ctest --parallel --output-on-failure
working-directory: build
run: ctest --test-dir build --parallel --output-on-failure

- name: Install project
run: cmake --install build
Expand Down Expand Up @@ -110,7 +108,7 @@ jobs:

steps:
- name: Checkout code
uses: actions/checkout@v1
uses: actions/checkout@v2

- name: Set up Python 3.x
uses: actions/setup-python@v1
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/PR-review.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Check out code.
uses: actions/checkout@v1
uses: actions/checkout@v2
- name: misspell
uses: reviewdog/action-misspell@v1
with:
Expand Down
8 changes: 3 additions & 5 deletions .github/workflows/ci_windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ name: CI_windows
on: [push, pull_request]

env:
CI: "ON"
CTEST_TIME_TIMEOUT: "5" # some failures hang forever
CMAKE_GENERATOR: Ninja

jobs:
msys2-build:
Expand Down Expand Up @@ -58,8 +58,7 @@ jobs:
run: pip install fypp

- run: >-
cmake -G Ninja
-DCMAKE_SH="CMAKE_SH-NOTFOUND"
cmake
-Wdev
-B build
-DCMAKE_BUILD_TYPE=Debug
Expand All @@ -79,8 +78,7 @@ jobs:
if: failure()

- name: CTest
run: ctest --output-on-failure --parallel -V -LE quadruple_precision
working-directory: build
run: ctest --test-dir build --output-on-failure --parallel -V -LE quadruple_precision

- uses: actions/upload-artifact@v1
if: failure()
Expand Down