Sorting4 #439
Merged
Sorting4 #439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed sorted integer array from size 2**20 to size 2**16 Changed sorted character array from size 26**4 to 16**4, so the four characters are a-p. Changed sorted string array from size 26**3 to 16**3, so the four characters are a-p. Change format for the run times from F10.5 to F10.6 to give at least three digits of precision. [ticket: X]
Broke up seveeral lines so that the source code would be conistenly no more than 80 columns. [ticket: X]
Changed the format of a couple of commets so they were less than 80 columns wide. [ticket: X]
Changes two comments so that they are less than 80 columns wide. [ticket: X]
I got confused and in my commit of stdlib_sorting.md thought I was committing stdlib_sorting.fypp. The commit to stdlib_sorting.md actualy documented the changes in the output of test_sorting.f90, i.e., the reduction in the size of the arrays being sorted, so the runtime of test_sorting.f90 would be less than 1 second. [ticket: X]
|
I have made the test code, |
jvdp1
approved these changes
Jun 21, 2021
The code had two contexts in which it used the literal value 16. First for power of two number of elements in the integer arrays. Second for the number of characters in the character set used to generate character arrays and strings. For the first conext I defined the parameter test_power. For the second context I defined the parameter char_set_size, bot with the value of 16. [ticket: X]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
src/tests/sorting/test_sorting.f90so that it should run in under one second, by reducing the length of the arrays being sorted, and setting the number of repeats to 1. Changeddoc/specs/stdlib_sorting.mdso its discussion of the output oftest_sorting.f90reflected the changes in the code. Changed two comments insrc/stdlib_sorting.fyppso they were less than 80 columns wide.