Skip to content

Add separate logical kind parameters #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 7, 2021
Merged

Add separate logical kind parameters #424

merged 3 commits into from
Jun 7, 2021

Conversation

awvwgk
Copy link
Member

@awvwgk awvwgk commented Jun 4, 2021

  • added logical kind parameters to stdlib_kinds:
    • lp: logical precision of default logical variables (name open for discussion)
    • c_bool: reexport from iso_c_binding
  • created LOG_KINDS, LOG_TYPES and LOG_KINDS_TYPES macros
  • updated to_string generator to use LOG_KINDS
  • documented stdlib_kinds module in specification

Closes #423

@awvwgk awvwgk requested review from arjenmarkus and jvdp1 June 4, 2021 08:17
@awvwgk awvwgk added the reviewers needed This patch requires extra eyes label Jun 4, 2021
arjenmarkus
arjenmarkus approved these changes Jun 4, 2021
View reviewed changes
Copy link
Member

@arjenmarkus arjenmarkus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me - the name "lp" is not very attractive, but I have no alternative that is any better.

jvdp1
jvdp1 approved these changes Jun 4, 2021
View reviewed changes
Copy link
Member

@jvdp1 jvdp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. While I don't really like the abbreviation lp (to what refer the p?). However, I don't have an appropriate alternative (e.g., log_kind, lk, def_log)?

@awvwgk
Copy link
Member Author

awvwgk commented Jun 4, 2021

Renamed from lp to lk.

@jvdp1
Copy link
Member

jvdp1 commented Jun 6, 2021

Renamed from lp to lk.

I prefer lk. It could be merged IMO.

ivan-pi
ivan-pi approved these changes Jun 6, 2021
View reviewed changes
Copy link
Member

@ivan-pi ivan-pi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the single comment, I'm happy to see this merged.

milancurcic
milancurcic approved these changes Jun 7, 2021
View reviewed changes
Copy link
Member

@milancurcic milancurcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@awvwgk awvwgk merged commit 9929cdb into fortran-lang:master Jun 7, 2021
@awvwgk awvwgk deleted the logical-kind branch June 7, 2021 07:01
@awvwgk awvwgk removed the reviewers needed This patch requires extra eyes label Jun 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arjenmarkus arjenmarkus arjenmarkus approved these changes

@milancurcic milancurcic milancurcic approved these changes

@jvdp1 jvdp1 jvdp1 approved these changes

@ivan-pi ivan-pi ivan-pi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The stdlib_ascii module uses INT_KINDS instead of a list of logical kinds to generate to_string(logical)
5 participants
@awvwgk @jvdp1 @arjenmarkus @milancurcic @ivan-pi