Skip to content

Corrected Ubuntu version #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 31, 2021
Merged

Corrected Ubuntu version #415

merged 1 commit into from
May 31, 2021

Conversation

jvdp1
Copy link
Member

@jvdp1 jvdp1 commented May 24, 2021

The Ubuntu version used in CI is 20.04, instead of 18.04 as mentioned in the README.md

@jvdp1 jvdp1 requested review from milancurcic and awvwgk May 24, 2021 18:51
awvwgk
awvwgk approved these changes May 24, 2021
View reviewed changes
Copy link
Member

@awvwgk awvwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. There is GCC 11 now around for Ubuntu 21.04 and homebrew, maybe we can get this to work for stdlib testing as well.

@awvwgk awvwgk added the reviewers needed This patch requires extra eyes label May 31, 2021
@awvwgk awvwgk requested review from certik and LKedward May 31, 2021 08:32
LKedward
LKedward approved these changes May 31, 2021
View reviewed changes
Copy link
Member

@LKedward LKedward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@awvwgk awvwgk merged commit 7b509a2 into fortran-lang:master May 31, 2021
@awvwgk awvwgk removed the reviewers needed This patch requires extra eyes label Jun 12, 2021
@jvdp1 jvdp1 deleted the typo_readme branch December 22, 2021 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LKedward LKedward LKedward approved these changes

@awvwgk awvwgk awvwgk approved these changes

@milancurcic milancurcic Awaiting requested review from milancurcic

@certik certik Awaiting requested review from certik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jvdp1 @LKedward @awvwgk