Skip to content

Add Intel compiler workflow for OSX #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 23, 2021
Merged

Add Intel compiler workflow for OSX #367

merged 2 commits into from
Apr 23, 2021

Conversation

awvwgk
Copy link
Member

@awvwgk awvwgk commented Mar 28, 2021 •
edited
Loading

Expand our compiler testing with Intel oneAPI classic 2021.1 on OSX. It also removes the -standard-semantics flag from the options for Intel Fortran.

GitHub actions workflow is taken from https://github.com/oneapi-src/oneapi-ci (MIT licensed).

Closes #369
Closes #298

@awvwgk awvwgk mentioned this pull request Mar 28, 2021
Closed
@awvwgk awvwgk marked this pull request as draft March 28, 2021 16:14
@awvwgk awvwgk marked this pull request as ready for review April 8, 2021 18:59
everythingfunctional
everythingfunctional approved these changes Apr 8, 2021
View reviewed changes
Copy link
Member

@everythingfunctional everythingfunctional left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Note that Intel doesn't support coarrays on Mac, so if stdlib starts using any parallel features at some point this might fail.

@awvwgk awvwgk added the reviewers needed This patch requires extra eyes label Apr 18, 2021
jvdp1
jvdp1 approved these changes Apr 21, 2021
View reviewed changes
Copy link
Member

@jvdp1 jvdp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It can be merged IMO

@awvwgk awvwgk removed the reviewers needed This patch requires extra eyes label Apr 21, 2021
@awvwgk awvwgk merged commit 274bd69 into fortran-lang:master Apr 23, 2021
@awvwgk awvwgk deleted the intel branch April 23, 2021 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@everythingfunctional everythingfunctional everythingfunctional approved these changes

@jvdp1 jvdp1 jvdp1 approved these changes

@certik certik Awaiting requested review from certik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Intel oneAPI fails to compile stdlib on OSX Intel Fortran and -standard-semantics
3 participants
@awvwgk @everythingfunctional @jvdp1