Fix dependencies in manual Makefile #294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- also build in parallel using the manual makefile
|
|
Closed
jvdp1
approved these changes
Jan 17, 2021
milancurcic
approved these changes
Jan 18, 2021
There was a problem hiding this comment.
I tested it and it works. I will go ahead and merge. Thanks @awvwgk!
milancurcic
added a commit
that referenced
this pull request
Jan 18, 2021
Fix some issues with Makefiles mentioned in #294
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the manual Makefile by including the correct dependencies. The manual Makefile build could fail in full parallel builds due to missing dependencies.
To test this use a slow computer and let make create as many build jobs as allowed by the dependency network with:
This error might be hard to catch in a sequential CI build due to the correct ordering of the source files in
SRCvariable.