Issue with logger s configuration subroutine

[jvdp1]

@wclodius2
I found a small issue within stdlib_logger. If the subroutine configuration is called and no units are associated with the logger, self % log_units is not allocated, and leads to a segfault (in debug mode) when the program tries to use it for allocating log_units.
With my proposition, log_units will be a zero-sized array in such situations (as it is tested like that in the tests).

[wclodius2]

@jvdp1 the two changes look good to me. Sorry for missing that problem.

[wclodius2]

It looks to me like your changes are for a PR against the master, and not against logger-safe-async-io. I don't believe I have write access to the master repository so I can't do a merge there. Do you want me to copy the changes to logger-safe-async-io and we just do a merge of that, or did you have other ideas?

[jvdp1]

It looks to me like your changes are for a PR against the master, and not against logger-safe-async-io. I don't believe I have write access to the master repository so I can't do a merge there. Do you want me to copy the changes to logger-safe-async-io and we just do a merge of that, or did you have other ideas?

Thank you for the approcal.
Since it is a small change and that it is not related to logger-safe-async-io, I will merge it in master.
Anyway, I can open a PR to logger-safe-async-io if you want, but I don't think it is needed at this stage.

[wclodius2]

Will git pull https://github.com/fortran-lang/stdlib merge your changes into my local version of logger-safe-async-io so it can them be pushed?

[jvdp1]

Will git pull https://github.com/fortran-lang/stdlib merge your changes into my local version of logger-safe-async-io so it can them be pushed?

In you local directory, you could do:

git checkout logger-safe-async-io
git fetch upstream master    #assuming upstream points to github.com/fortran-lang/stdlib
git merge --no-ff upstream/master
git push origin logger-safe-async-io

[wclodius2]

git merge --no-ff upstream/master

gives me

merge: upstream/stdlib - not something we can merge

[jvdp1]

It seems you tried: git merge --no-ff upstream/stdlib instead of git merge --no-ff upstream/master Le mer. 25 nov. 2020 à 20:34, William B. Clodius <notifications@github.com> a écrit :

…

git merge --no-ff upstream/master gives me merge: upstream/stdlib - not something we can merge — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#252 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AD5RO7FW5DKXOI7KMQYVC4TSRVL2VANCNFSM4UB7SKNQ> .

[wclodius2]

All of the following gives the same result

stdlib % git merge --no-ff upstream/master
merge: upstream/master - not something we can merge

git merge --no-ff https://github.com/fortran-lang/stdlib/master
merge: https://github.com/fortran-lang/stdlib/master - not something we can merge

git merge --no-ff https://github.com/fortran-lang/stdlib      
merge: https://github.com/fortran-lang/stdlib - not something we can merge

git merge --no-ff github.com/fortran-lang/stdlib/master      
merge: github.com/fortran-lang/stdlib/master - not something we can merge

[jvdp1]

All of the following gives the same result

stdlib % git merge --no-ff upstream/master
merge: upstream/master - not something we can merge

git merge --no-ff https://github.com/fortran-lang/stdlib/master
merge: https://github.com/fortran-lang/stdlib/master - not something we can merge

git merge --no-ff https://github.com/fortran-lang/stdlib      
merge: https://github.com/fortran-lang/stdlib - not something we can merge

git merge --no-ff github.com/fortran-lang/stdlib/master      
merge: github.com/fortran-lang/stdlib/master - not something we can merge

Is upstream associated with www.github.com/fortran-lang/stdlib ? What does git remote -v return?

[wclodius2]

git remote -v
origin	https://github.com/fortran-lang/stdlib (fetch)
origin	https://github.com/fortran-lang/stdlib (push)
william	git@github.com:wclodius2/stdlib.git (fetch)
william	git@github.com:wclodius2/stdlib.git (push)

[jvdp1]

git remote -v
origin	https://github.com/fortran-lang/stdlib (fetch)
origin	https://github.com/fortran-lang/stdlib (push)
william	git@github.com:wclodius2/stdlib.git (fetch)
william	git@github.com:wclodius2/stdlib.git (push)

Ok. I understand. Your origin is what I call upstream. The following should work:

git checkout logger-safe-async-io
git fetch origin master
git merge --no-ff origin/master
git push william logger-safe-async-io

[wclodius2]

Thanks its merged into logger-safe-async-io now.