Skip to content

Replace make_directory with file(MAKE_DIRECTORY <directories>...) #954

Closed
@jfdev001

Description

@jfdev001

Per https://cmake.org/cmake/help/latest/command/make_directory.html, the command

make_directory

is deprecated since cmake 3.0 and file(MAKE_DIRECTORY <directories>...) should be used instead (see https://cmake.org/cmake/help/latest/command/file.html#make-directory).

make_directory is used in the following files:

make_directory("${LIB_MOD_DIR}")

make_directory("${${_pkg}_BINARY_DIR}/include")

make_directory("${${_pkg}_BINARY_DIR}/include")

Since the cmake minimum version for the project is 3.14 anyways, I think it would make sense to use the recommended method (i.e., file(MAKE_DIRECTORY)) of creating directories. If this change makes sense, I can go ahead and open PR to make the necessary substitution.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions