Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[image_picker]: Bump mockito-core from 3.10.0 to 4.8.0 in /packages/image_picker/image_picker_android/android #6381

Merged
merged 3 commits into from
Sep 13, 2022
Merged

[image_picker]: Bump mockito-core from 3.10.0 to 4.8.0 in /packages/image_picker/image_picker_android/android #6381

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ef71fd0
[image_picker]: Bump mockito-core
dependabot[bot] Sep 12, 2022
d2e3e48
Update tests for API changes
stuartmorgan-g Sep 12, 2022
20c7f14
format
stuartmorgan-g Sep 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/image_picker/image_picker_android/android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ android {
implementation 'androidx.exifinterface:exifinterface:1.3.3'

testImplementation 'junit:junit:4.13.2'
testImplementation 'org.mockito:mockito-core:3.10.0'
testImplementation 'org.mockito:mockito-core:4.8.0'
testImplementation 'androidx.test:core:1.4.0'
testImplementation "org.robolectric:robolectric:4.8.1"
}
Expand Down
18 changes: 9 additions & 9 deletions ...r_android/android/src/test/java/io/flutter/plugins/imagepicker/ImagePickerPluginTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.times;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.verifyZeroInteractions;
import static org.mockito.Mockito.verifyNoInteractions;
import static org.mockito.Mockito.when;

import android.app.Activity;
Expand Down Expand Up @@ -76,49 +76,49 @@ public void onMethodCall_WhenActivityIsNull_FinishesWithForegroundActivityRequir
imagePickerPluginWithNullActivity.onMethodCall(call, mockResult);
verify(mockResult)
.error("no_activity", "image_picker plugin requires a foreground activity.", null);
verifyZeroInteractions(mockImagePickerDelegate);
verifyNoInteractions(mockImagePickerDelegate);
}

@Test
public void onMethodCall_WhenCalledWithUnknownMethod_ThrowsException() {
exception.expect(IllegalArgumentException.class);
exception.expectMessage("Unknown method test");
plugin.onMethodCall(new MethodCall("test", null), mockResult);
verifyZeroInteractions(mockImagePickerDelegate);
verifyZeroInteractions(mockResult);
verifyNoInteractions(mockImagePickerDelegate);
verifyNoInteractions(mockResult);
}

@Test
public void onMethodCall_WhenCalledWithUnknownImageSource_ThrowsException() {
exception.expect(IllegalArgumentException.class);
exception.expectMessage("Invalid image source: -1");
plugin.onMethodCall(buildMethodCall(PICK_IMAGE, -1), mockResult);
verifyZeroInteractions(mockImagePickerDelegate);
verifyZeroInteractions(mockResult);
verifyNoInteractions(mockImagePickerDelegate);
verifyNoInteractions(mockResult);
}

@Test
public void onMethodCall_WhenSourceIsGallery_InvokesChooseImageFromGallery() {
MethodCall call = buildMethodCall(PICK_IMAGE, SOURCE_GALLERY);
plugin.onMethodCall(call, mockResult);
verify(mockImagePickerDelegate).chooseImageFromGallery(eq(call), any());
verifyZeroInteractions(mockResult);
verifyNoInteractions(mockResult);
}

@Test
public void onMethodCall_InvokesChooseMultiImageFromGallery() {
MethodCall call = buildMethodCall(PICK_MULTI_IMAGE);
plugin.onMethodCall(call, mockResult);
verify(mockImagePickerDelegate).chooseMultiImageFromGallery(eq(call), any());
verifyZeroInteractions(mockResult);
verifyNoInteractions(mockResult);
}

@Test
public void onMethodCall_WhenSourceIsCamera_InvokesTakeImageWithCamera() {
MethodCall call = buildMethodCall(PICK_IMAGE, SOURCE_CAMERA);
plugin.onMethodCall(call, mockResult);
verify(mockImagePickerDelegate).takeImageWithCamera(eq(call), any());
verifyZeroInteractions(mockResult);
verifyNoInteractions(mockResult);
}

@Test
Expand Down