-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[various] Update example apps to Swift #9347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
stuartmorgan-g
wants to merge
23
commits into
flutter:main
Choose a base branch
from
stuartmorgan-g:swift-example-apps
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CHANGELOG override: build details of example apps are not relevant to clients. |
tarrinneal
approved these changes
May 30, 2025
Version override: The |
@jmagman / @vashworth Do you want me to wait for someone on the iOS team to review this, or should I just land it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
override: no changelog needed
Override the check requiring CHANGELOG updates for most changes
override: no versioning needed
Override the check requiring version bumps for most changes
p: camera
p: extension_google_sign_in_as_googleapis_auth
p: google_maps_flutter
p: google_sign_in
p: image_picker
p: in_app_purchase
p: local_auth
p: path_provider
p: quick_actions
p: shared_preferences
p: url_launcher
p: video_player
p: webview_flutter
platform-ios
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts the Objective-C iOS example apps for all non-iOS-plugin-implementation packages to Swift.
The process for this was (all using current
stable
, 3.32):flutter create --platforms=ios .
.ios/Runner/Assets.xcassets/AppIcon.appiconset
(this doesn't really matter either way, I just decided not to thrash a bunch of icons, since there's no real reason to and it would have added a ton more files).ios/
, except for.gitignore
which we may as well have a current version of.RunnerTest
target, its source file, and thePodfile
adjustment toRunnerTest
.io.flutter.*
org the examples were first created with.Info.plist
.One-off changes:
Configuration.storkekit
in in_app_purchase.I did not convert the implementation packages in this PR because those will need to be handled more carefully, due to the presence of RunnerTest (and sometimes RunnerUITest) targets that need to be preserved.
Part of flutter/flutter#148586
Pre-Review Checklist
[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///
).Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3