Skip to content

[various] Update example apps to Swift #9347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 23 commits into
base: main
Choose a base branch
from

Conversation

stuartmorgan-g
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g commented May 30, 2025

Converts the Objective-C iOS example apps for all non-iOS-plugin-implementation packages to Swift.

The process for this was (all using current stable, 3.32):

  • Deleted example/ios.
  • Ran flutter create --platforms=ios ..
  • Reverted changes in ios/Runner/Assets.xcassets/AppIcon.appiconset (this doesn't really matter either way, I just decided not to thrash a bunch of icons, since there's no real reason to and it would have added a ton more files).
  • Reverted changes outside of ios/, except for .gitignore which we may as well have a current version of.
  • Added license blocks to template-created code files.
  • Removed the RunnerTest target, its source file, and the Podfile adjustment to RunnerTest.
  • Reverted bundle identifier changes in most cases, since it was often auto-detecting the old io.flutter.* org the examples were first created with.
  • Re-added any important bits to Info.plist.
  • Ran a build both with and without SwiftPM enabled, to ensure that all the Cocoapods and SwiftPM boilerplate is added to the projects to cut down on random diffs when people build later.

One-off changes:

  • Added back Configuration.storkekit in in_app_purchase.
  • Migrated the Google Maps API key code in AppDelegate.m to AppDelegate.swift

I did not convert the implementation packages in this PR because those will need to be handled more carefully, due to the presence of RunnerTest (and sometimes RunnerUITest) targets that need to be preserved.

Part of flutter/flutter#148586

Pre-Review Checklist

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

@stuartmorgan-g
Copy link
Contributor Author

CHANGELOG override: build details of example apps are not relevant to clients.

@stuartmorgan-g stuartmorgan-g added the override: no versioning needed Override the check requiring version bumps for most changes label Jun 2, 2025
@stuartmorgan-g
Copy link
Contributor Author

Version override: The false_secrets removal in extension_google_sign_in_as_googleapis_auth's pubspec.yaml flags for a version change, but that's not something that matters if we publish.

@stuartmorgan-g
Copy link
Contributor Author

@jmagman / @vashworth Do you want me to wait for someone on the iOS team to review this, or should I just land it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants