[google_sign_in] Redesign API for current identity SDKs #9267

stuartmorgan-g · 2025-05-16T17:54:14Z

This is a full overhaul of the google_sign_in API, with breaking changes for all component packages—including the platform interface. The usual model of adding the new approach while keeping the old one is not viable here, as the underlying SDKs have changed significantly since the original API was designed. Web already had some only-partially-compatible shims for this reason, and Android would have had to do something similar; see flutter/flutter#119300 and flutter/flutter#154205, and the design doc for more background.

Fixes [google_sign_in] Rework google_sign_in to reflect changes in underlying SDKs flutter#119300
Fixes [google_sign_in] Switch Android to Credential Manager flutter#154205
Fixes [google_sign_in_web] Enable incremental authorization for Code Model. flutter#139406
Fixes [google_sign_in_android] Remove deprecated API usages in most recent version of play-services-auth flutter#150365
Fixes [google_sign_in_web] Remove deprecated signIn method. flutter#137727
Fixes [google_sign_in] Implement canAccessScopes on mobile flutter#124206
Fixes google_sign_in plugin links to obsolete documentation for web flutter#117794
Fixes [google_sign_in] Android documentation is wrong flutter#107532
Fixes [google_sign_in] Support passing a nonce flutter#85439
Fixes [google_sign_in] java.lang.NullPointerException: Attempt to read from field [...] on a null object reference flutter#74308
Fixes [google_sign_in] Add future that completes when the plugin is (really) ready. flutter#71607
Fixes [google_sign_in_web] googleSignIn.signIn() hangs forever if can't connect to apis.google.com flutter#70427
Fixes [google_sign_in] better error handling flutter#32441 (there may be more to do here over time, since we may find exceptions that are not caught, but we now have a structured system to convert errors to as we find specific unhandled cases)

Pre-Review Checklist

Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩² ↩³

Also reworks app-facing package example app for testing.

camsim99

Reviewed the Android implementation!

camsim99 · 2025-05-23T16:57:23Z

packages/google_sign_in/google_sign_in_android/lib/google_sign_in_android.dart

+  Future<PlatformGoogleIdTokenCredential?> _authenticate({
+    required bool filterToAuthorized,
+    required bool autoSelectEnabled,
+    required bool useButtonFlow,


So if useButtonFlow is true, then basically the other options are ignored? Would it be helpful to warn users here about that?

I've added a wrapper class at this layer and the Pigeon layer that encapsulate the options that are specific to the non-button flow, and also added some docs, to make things clearer.

I've reworked the API here and at the Pigeon layer to put the options specific to non-button-flow in a class, and added comments, to make it clearer what doesn't apply. (When I first wrote this code I didn't use the button flow, so the flat arguments made sense.)

Ok cool this is much clearer, thank you!

...ign_in_android/android/src/main/java/io/flutter/plugins/googlesignin/GoogleSignInPlugin.java

packages/google_sign_in/google_sign_in_android/lib/google_sign_in_android.dart

..._sign_in_android/android/src/test/java/io/flutter/plugins/googlesignin/GoogleSignInTest.java

camsim99 · 2025-05-23T21:25:51Z

..._sign_in_android/android/src/test/java/io/flutter/plugins/googlesignin/GoogleSignInTest.java

+        ResultCompat.asCompatCallback(
+            reply -> {
+              // This is never called, since this test doesn't trigger the getCredentialsAsync callback.
+              return null;


Nit: could throw an exception to ensure it's not called.

Added fail() to all of these, and adjusted the comment slightly to explain why.

..._sign_in_android/android/src/test/java/io/flutter/plugins/googlesignin/GoogleSignInTest.java

camsim99 · 2025-05-23T22:10:15Z

packages/google_sign_in/google_sign_in_android/README.md

@@ -13,3 +13,28 @@ should add it to your `pubspec.yaml` as usual.

 [1]: https://pub.dev/packages/google_sign_in
 [2]: https://flutter.dev/to/endorsed-federated-plugin
+
+## Integration


Can we consider linking to the credentials docs on this? https://developer.android.com/identity/sign-in/credential-manager-siwg#set-google for the non-firebase option? If it's more confusing than helpful because some steps don't apply, maybe not though.

By the time I was updating the READMEs I was so used to skipping down to the code on that page I forgot it had setup instructions! I've adjusted to link to that as the non-Firebase option, and removed some of the details since they are covered more thoroughly there.

Hahaha totally understandable! LGTM!

camsim99

The Android implementation LGTM!

camsim99 · 2025-06-02T16:14:00Z

packages/google_sign_in/google_sign_in_android/lib/google_sign_in_android.dart

+  Future<PlatformGoogleIdTokenCredential?> _authenticate({
+    required bool filterToAuthorized,
+    required bool autoSelectEnabled,
+    required bool useButtonFlow,


Ok cool this is much clearer, thank you!

camsim99 · 2025-06-02T16:27:54Z

packages/google_sign_in/google_sign_in_android/README.md

@@ -13,3 +13,28 @@ should add it to your `pubspec.yaml` as usual.

 [1]: https://pub.dev/packages/google_sign_in
 [2]: https://flutter.dev/to/endorsed-federated-plugin
+
+## Integration


Hahaha totally understandable! LGTM!

stuartmorgan-g · 2025-06-03T15:00:12Z

@LongCatIsLooong / @cbracken Ping on the iOS portion of this review.

stuartmorgan-g · 2025-06-03T15:00:55Z

@bparrishMines Could you review the platform interface and app-facing package changes?

LongCatIsLooong

As someone that's new to this plugin, thanks for the design doc! I still have a few questions after reading the doc.

LongCatIsLooong · 2025-06-03T16:28:42Z

packages/google_sign_in/google_sign_in/README.md


 ### Requesting more scopes when needed

 If an app determines that the user hasn't granted the scopes it requires, it
-should initiate an Authorization request. (Remember that in the web platform,
-this request **must be initiated from an user interaction**, like a button press).
+should initiate an Authorization request. On some platforms, such as web,


nit: this sounds like there are platforms other than web where user interactions are required for Authorization request. Is that the case? How do I know which of the platforms my app targets have such restriction?

supportsAuthenticate? But that's for authentication I assume?

LongCatIsLooong · 2025-06-03T16:56:40Z

packages/google_sign_in/google_sign_in/example/lib/main.dart

-      }
-// #enddocregion CanAccessScopes
+    // #docregion Setup
+    final GoogleSignIn signIn = GoogleSignIn.instance;


Hmm this reminds me of flutter/flutter#168100, if the user connects / disconnects a mouse / keyboard on Android the activity will restart and that would result in the element tree being re-inflated anew.

I guess that does not break the new flow (from reading the docs initialize has to be called exactly once in a program) since the new activity will spin up a new dart vm? Still it would be an annoyance that every time I unplug my keyboard I have to go over the sign-in process again.

Or when the activity restarts, the lightweight authentication path will be taken and the flow will typically be invisible to user / require no additional user interactions?

EDIT: Just read the design doc and it mentioned "Fully silent sign in is no longer available"

LongCatIsLooong · 2025-06-03T17:00:14Z

packages/google_sign_in/google_sign_in/example/lib/main.dart

+  Future<void> _handleAuthenticationEvent(
+      GoogleSignInAuthenticationEvent event) async {
+    // #docregion CheckAuthorization
+    GoogleSignInAccount? user;


uber nit, consider making user and authorization final if possible?

LongCatIsLooong · 2025-06-03T17:23:16Z

packages/google_sign_in/google_sign_in/lib/google_sign_in.dart

  ///
-  /// Returned Future resolves to an instance of [GoogleSignInAccount] for a
-  /// successful sign in or `null` in case sign in process was aborted.
+  /// If this returns false, [authenticate] will throw an UnsupportedError if


nit: missing backticks / square brackets around UnsupportedError?

LongCatIsLooong · 2025-06-03T17:23:30Z

packages/google_sign_in/google_sign_in/lib/google_sign_in.dart

-  /// successful sign in or `null` in case sign in process was aborted.
+  /// If this returns false, [authenticate] will throw an UnsupportedError if
+  /// called. See the platform-specific documentation for the package to
+  /// determine how authentication his handled. For instance, the platform may


LongCatIsLooong · 2025-06-03T17:32:18Z

packages/google_sign_in/google_sign_in/lib/src/event_types.dart

+
+/// A base class for authentication event streams.
+@immutable
+sealed class GoogleSignInAuthenticationEvent {


Are these classes needed? It seems the sealed type is a glorified GoogleSignInAccount?.

LongCatIsLooong · 2025-06-03T17:39:56Z

...gle_sign_in_ios/darwin/google_sign_in_ios/Sources/google_sign_in_ios/FLTGoogleSignInPlugin.m


 // The plugin registrar, for querying views.
-@property(strong, nonnull) id<FlutterPluginRegistrar> registrar;
+@property(nonatomic) id<FlutterPluginRegistrar> registrar;


is this still nonnull?

LongCatIsLooong · 2025-06-03T18:07:18Z

...gle_sign_in_ios/darwin/google_sign_in_ios/Sources/google_sign_in_ios/FLTGoogleSignInPlugin.m

-       completion:(nullable void (^)(GIDSignInResult *_Nullable signInResult,
-                                     NSError *_Nullable error))completion {
-  GIDGoogleUser *currentUser = self.signIn.currentUser;
+    forGoogleSignInUser:(GIDGoogleUser *)user


I assume the user argument is not nullable, otherwise it's failing silently?

LongCatIsLooong · 2025-06-03T18:09:50Z

...gle_sign_in_ios/darwin/google_sign_in_ios/Sources/google_sign_in_ios/FLTGoogleSignInPlugin.m

  }];
 }

+- (void)addScopes:(nonnull NSArray<NSString *> *)scopes
+          forUser:(NSString *)userId


can userId be null?

LongCatIsLooong · 2025-06-03T18:18:03Z

...gle_sign_in_ios/darwin/google_sign_in_ios/Sources/google_sign_in_ios/FLTGoogleSignInPlugin.m

 - (void)signOutWithError:(FlutterError *_Nullable *_Nonnull)error {
  [self.signIn signOut];
+  [self.usersByIdentifier removeAllObjects];


The signOut method seems to only sign out the current user: https://developers.google.com/identity/sign-in/ios/reference/Classes/GIDSignIn

Why do we have to remove everything in the dictionary? If refreshedAuthorizationTokensForUser gets called for a different user (is that possible`?) the app would get an error it seems?

stuartmorgan-g added 20 commits May 15, 2025 11:11

Initial PoC using CredentialManager

432a627

Pathify everything for local development

df1cf87

Remove method channel implementation

6a1ec7c

First pass rework of interface, impls, and app-facing API

49342c5

Also reworks app-facing package example app for testing.

Add nonce support

eba7a8b

Initial README updates and migration guide

f3d472f

Rework Android calls to match recommended practice

728a4f9

Synthesize sign-out event for disconnect

c165834

platform interface tests

dba0f3e

Simplify Android Pigeon API

83c7b1d

Android Dart unit tests

82c0530

iOS Dart unit tests

4123b18

Web Dart 'unit' tests, and fix lightweight auth return

165fb78

Update example apps

eda66bb

Update native unit tests, fix an Obj-C selector name

21635a0

Update to recent 1.5 release

39b7505

Android native unit tests

07fe543

README, CHANGELOG, and version updates

e6c9f62

App-facing Dart tests

90a63aa

Revert unrelated Xcode project changes

816f614

stuartmorgan-g requested review from LongCatIsLooong, cbracken, camsim99 and ditman as code owners May 16, 2025 17:54

github-actions bot added p: extension_google_sign_in_as_googleapis_auth p: google_sign_in platform-android platform-ios platform-macos platform-web labels May 16, 2025

camsim99 reviewed May 23, 2025

View reviewed changes

stuartmorgan-g added 12 commits May 27, 2025 12:30

Merge branch 'main' into google-sign-in-authn-authz-redesign

8783b72

Remove email scope

7140fd0

Web README additions

5a587b4

Update stream error handling, update main example

5f78e10

Fix lightweight auth null return, and add missing tests

a6036b8

Re-add web asserts for scope spaces

9c9923c

Remove unused People code

b44ff39

Restructure options slightly

8640443

Add TODO issue link

86a7a1d

Add activity lifecycle tests

4fb7fea

Add authorize param tests

563680c

Test safety check, better README

dab117f

stuartmorgan-g requested a review from ash2moon as a code owner May 29, 2025 02:07

stuartmorgan-g requested review from camsim99 and ditman May 29, 2025 02:07

stuartmorgan-g added 4 commits May 29, 2025 08:25

Analyzer

81f59f7

Java autoformat

6b76be0

excerpt update

9817325

Add stack traces to stream errors

20a8fc5

stuartmorgan-g added the triage-ios Should be looked at in iOS triage label May 29, 2025

stuartmorgan-g added 4 commits May 29, 2025 11:24

Handle emulators without sign-in support

d6bd8bc

Add another missing stack

6766860

Rework the stream tests to make wasm happy

8ad0051

Merge branch 'main' into google-sign-in-authn-authz-redesign

9fe4f32

camsim99 approved these changes Jun 2, 2025

View reviewed changes

stuartmorgan-g requested a review from bparrishMines June 3, 2025 15:00

LongCatIsLooong reviewed Jun 3, 2025

View reviewed changes

[google_sign_in] Redesign API for current identity SDKs #9267

Are you sure you want to change the base?

[google_sign_in] Redesign API for current identity SDKs #9267

Uh oh!

Conversation

stuartmorgan-g commented May 16, 2025

Pre-Review Checklist

Footnotes

Uh oh!

camsim99 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

camsim99 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g commented Jun 3, 2025

Uh oh!

stuartmorgan-g commented Jun 3, 2025

Uh oh!

LongCatIsLooong left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!