[android_camera_camerax] Fix incorrect camera mirroring for front cameras on devices using ImageReader Impeller backend
#9233
+180
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jesswrd
changed the title
ImageReader Impeller backendImageReader Impeller backend
jesswrd
changed the title
ImageReader Impeller backendImageReader Impeller backend
camsim99
commented
Jun 3, 2025
|
|
||
| // Since the front camera is in portrait mode, we expect the camera | ||
| // preview to be mirrored across the y-axis. | ||
| expect(transformedPreviewMatrix.storage[5], closeTo(-1.0, 0.0001)); |
There was a problem hiding this comment.
What do you think about creating a helper method for these sorts of checks? Something like checkYAxisIsMirrored(double matrixArg5) and checkXAxisIsMirrored(double matrixArg0) with docs for both explaining why this checks what we think? I think this may help for clarity in the future.
|
|
||
| // Since the front camera is in landscape mode, we expect the camera | ||
| // preview to be mirrored across the x-axis. | ||
| expect(transformedPreviewMatrix.storage[0], closeTo(-1.0, 0.0001)); |
There was a problem hiding this comment.
I assume the closeTo is because a precision error? If there's no workaround for that, can you add a comment here (or to the helper methods if you're open to adding them) about that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the incorrect camera mirroring when the front camera is used on devices that use the
ImageReaderImpeller backend. TLDR: for relevant rotated preview implementation, when the front camera is used, mirror the camera preview across the y-axis when the device is in a portrait orientation or across the x-axis when the device is in a landscape orientation.Fixes flutter/flutter#156974.
cc @jesswrd, co-author of this PR
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3