Skip to content

Update get_document.js #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 4, 2023
Merged

Conversation

Shabbirjodhpur
Copy link
Contributor

We get the snapshot of data using 'getDoc()' and get result 'docSnap' And then we perform check on this 'docSnap' in the if else block So in the else block the comment should ne docSnap.data() will ne undefined

We get the snapshot of data using 'getDoc()' and get result 'docSnap'
And then we perform check on this 'docSnap' in the if else block
So in the else block the comment should ne docSnap.data() will ne undefined
@google-cla
Copy link

google-cla bot commented Apr 4, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@thatfiredev
Copy link
Member

@Shabbirjodhpur good find!

However, this file was generated from firestore-next/test.firestore.js:

// doc.data() will be undefined in this case

Can you please edit that file instead?

And then you should run npm run snippets to re-generate the appropriate files and commit them.

Thanks!

Copy link
Member

@thatfiredev thatfiredev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

Thank you @Shabbirjodhpur !

@thatfiredev thatfiredev merged commit e2beb93 into firebase:master Apr 4, 2023
@Shabbirjodhpur
Copy link
Contributor Author

This was my first PR !!! I am so excited!! It was great working on it !!!

thatfiredev pushed a commit that referenced this pull request May 22, 2023
We get the snapshot of data using 'getDoc()' and get result 'docSnap'
And then we perform check on this 'docSnap' in the if else block
So in the else block the comment should ne docSnap.data() will ne undefined
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants