Skip to content

Update gstatic url for v8 example #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 15, 2023

Conversation

dwyfrequency
Copy link
Contributor

@dwyfrequency dwyfrequency commented Feb 15, 2023

Update service-worker snippet with correct v8 url

Referenced in issue firebase/firebase-js-sdk#7030

Copy link
Member

@thatfiredev thatfiredev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dwyfrequency good catch! I just added a comment bellow

dwyfrequency and others added 2 commits February 15, 2023 13:25
Remove trailing comma

Co-authored-by: Rosário Pereira Fernandes <rosariofernandes51@gmail.com>
Revert to original line formatting for import script

Co-authored-by: Rosário Pereira Fernandes <rosariofernandes51@gmail.com>
Copy link
Member

@thatfiredev thatfiredev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks @dwyfrequency !

@thatfiredev thatfiredev enabled auto-merge (squash) February 15, 2023 18:27
@thatfiredev thatfiredev merged commit 486e5c6 into firebase:master Feb 15, 2023
@tkhduracell
Copy link

tkhduracell commented Feb 25, 2023

  1. Is the file not supposed to be called firebase-messaging-sw.js ?
  2. Using import at the top gives an error. Uncaught SyntaxError: Cannot use import statement outside a module (at firebase-messaging-sw.js:1:1)

thatfiredev pushed a commit that referenced this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants