Skip to content

refactor: import getMessaging from firebase/messaging/sw instead #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 3, 2023
Merged

refactor: import getMessaging from firebase/messaging/sw instead #320

merged 2 commits into from
Feb 3, 2023

Conversation

thatfiredev
Copy link
Member

In order to use FCM in a service worker, getMessaging should be imported from firebase/messaging/sw.

Originally reported on StackOverflow

@thatfiredev thatfiredev requested a review from jhuleatt January 25, 2023 15:53
@jhuleatt
Copy link
Contributor

jhuleatt commented Feb 3, 2023

thanks for catching this! FYI @egilmorez @kroikie

@thatfiredev thatfiredev enabled auto-merge (squash) February 3, 2023 18:02
@thatfiredev thatfiredev merged commit b48560b into master Feb 3, 2023
thatfiredev added a commit that referenced this pull request May 22, 2023
@thatfiredev
refactor: import getMessaging from messaging/sw (#320)
4252826
@thatfiredev thatfiredev deleted the rpf-fix-fcm-sw-snippet branch May 22, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhuleatt jhuleatt jhuleatt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thatfiredev @jhuleatt