[perf] make initialize & get singleton lines more explicit for vNext #229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rachelsaunders
changed the title
rachelsaunders
changed the title
rachelsaunders
changed the title
|
@rachelsaunders from your If you want me to do it I can. |
samtstern
reviewed
Aug 23, 2021
| // [END perf_initialize_app] | ||
|
|
||
| // [START perf_singleton] | ||
| // Initialize Performance Monitoring and get a reference to the service | ||
| const perf = getPerformance(); | ||
| const perf = getPerformance(app); |
There was a problem hiding this comment.
This was an intentional change, but it's fine either way.
There was a problem hiding this comment.
@davideast said that he preferred being more explicit with the demo snippet to ensure folks know how it's actually working, but then folks can do whatever they want in their actual code.
There was a problem hiding this comment.
🤷 well a few months ago we removed this from all other snippets where possible:
#135
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.