chore: fix cs check, fix git-attributes, removed unused entrypoint.sh, fix cs #424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bshaffer
changed the title
bshaffer
changed the title
| @@ -111,7 +110,7 @@ public static function decode( | |||
| if (null === ($payload = static::jsonDecode($payloadRaw))) { | |||
| throw new UnexpectedValueException('Invalid claims encoding'); | |||
| } | |||
| if (is_array($payload)) { | |||
| if (\is_array($payload)) { | |||
There was a problem hiding this comment.
Is this the recommended syntax by the CS fixer?
There was a problem hiding this comment.
See https://cs.symfony.com/doc/rules/function_notation/native_function_invocation.html
We get a performance bump by prefixing certain functions with a backslash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.