Skip to content

Add missing doc block for $alg in JWT::encode() #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 13, 2022

Conversation

berrugo
Copy link

@berrugo berrugo commented Apr 8, 2022

The param $alg is missing on the php doc block for method encode() in class JWT (It ain't much but it's honest work)

@google-cla
Copy link

google-cla bot commented Apr 8, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

@bshaffer bshaffer merged commit a57a898 into firebase:main Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants