-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Use json_encode with option JSON_UNESCAPED_SLASHES #317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@bshaffer Why label |
Because it will break backwards compatibility and drop a supported version of PHP, semantic versioning requires that we tag it for a new major version. |
That is not necessarily the case: https://medium.com/@sampart/semantic-versioning-when-you-change-the-required-programming-language-version-16a3a3555c95 However I agree that it's best to include such updates in a nearby major release if there is one. |
@Krisell I meant changing the behavior of |
@bshaffer Why did you merged unrelated commits into my branch? |
I updated your branch with changes made to master so that your PR is up to date. |
When encoding JSON, use option JSON_UNESCAPED_SLASHES which allows to disable a non-standard unnecessary over-encoding of '/' as '\/' by json_encode. This option of json_encode is available on PHP 5.4+.
5540996
to
0835d8f
Compare
Rebased on top of |
@dolmen it's been a while, but could you resubmit this branch to the |
@bshaffer Have you heard about |
@dolmen yes i have. Why do you ask? |
When encoding JSON, use option JSON_UNESCAPED_SLASHES which allows to disable a non-standard unnecessary over-encoding of
/
as\/
byjson_encode
.This option of json_encode is available on PHP 5.4+.