-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Adding snippet tags for callable and task queue sample imports #1097
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhuleatt
reviewed
Aug 15, 2023
egilmorez
commented
Aug 15, 2023
egilmorez
commented
Aug 15, 2023
Co-authored-by: Jeff <3759507+jhuleatt@users.noreply.github.com>
Separating imports general to most/all TQ functions from imports specific to the sample.
egilmorez
commented
Aug 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the input Jeff!
Not sure why I think this, but I wanted to add the Admin SDK import to the general/required section. LMK if that might be valid.
Oooh yeah, Python . . . adding similar import bifurcation in Python samples and adding Kevin for review. Thanks! |
kevinthecheung
approved these changes
Aug 16, 2023
Co-authored-by: Kevin Cheung <kevinthecheung@users.noreply.github.com>
Co-authored-by: Kevin Cheung <kevinthecheung@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to do this for all the guides, since it seems to be widely requested and not as obvious as one might think.
Do I have this right for TQ though? Lots of imports iiuc!