Skip to content

Adding snippet tags for callable and task queue sample imports #1097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Aug 16, 2023

Conversation

egilmorez
Copy link
Contributor

I'd like to do this for all the guides, since it seems to be widely requested and not as obvious as one might think.

Do I have this right for TQ though? Lots of imports iiuc!

@egilmorez egilmorez requested review from jhuleatt and taeold August 2, 2023 21:13
egilmorez and others added 2 commits August 15, 2023 13:48
Co-authored-by: Jeff <3759507+jhuleatt@users.noreply.github.com>
Separating imports general to most/all TQ functions from imports specific to the sample.
Copy link
Contributor Author

@egilmorez egilmorez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the input Jeff!

Not sure why I think this, but I wanted to add the Admin SDK import to the general/required section. LMK if that might be valid.

@egilmorez
Copy link
Contributor Author

Oooh yeah, Python . . . adding similar import bifurcation in Python samples and adding Kevin for review.

Thanks!

egilmorez and others added 7 commits August 16, 2023 10:04
@egilmorez egilmorez merged commit 3313875 into main Aug 16, 2023
@egilmorez egilmorez deleted the eg-itag-callable branch August 16, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants