Skip to content

upgrade jsdoc pkgs #6661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 2, 2024
Merged

upgrade jsdoc pkgs #6661

merged 1 commit into from
Jan 2, 2024

Conversation

bkendall
Copy link
Contributor

@bkendall bkendall commented Jan 2, 2024

Description

This fixes the "invalid runtime" errors I get when installing the dev tools on master (I have a npm config that makes this error instead of warn):

:firebase-tools(0f9ccc790|master) » npm i
npm ERR! code EBADENGINE
npm ERR! engine Unsupported engine
npm ERR! engine Not compatible with your version of node/npm: @es-joy/jsdoccomment@0.36.1
npm ERR! notsup Not compatible with your version of node/npm: @es-joy/jsdoccomment@0.36.1
npm ERR! notsup Required: {"node":"^14 || ^16 || ^17 || ^18 || ^19"}
npm ERR! notsup Actual:   {"npm":"10.2.3","node":"v20.10.0"}

@bkendall bkendall requested a review from joehan January 2, 2024 20:31
@bkendall bkendall enabled auto-merge (squash) January 2, 2024 20:31
Copy link
Contributor

@joehan joehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0f9ccc7) 54.18% compared to head (dccf5c5) 54.18%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6661   +/-   ##
=======================================
  Coverage   54.18%   54.18%           
=======================================
  Files         347      347           
  Lines       24130    24130           
  Branches     4976     4976           
=======================================
  Hits        13075    13075           
  Misses       9855     9855           
  Partials     1200     1200           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bkendall bkendall merged commit 5a46646 into master Jan 2, 2024
@bkendall bkendall deleted the bk-update-jsdoc-pkgs branch January 2, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants