Skip to content

Updated to only show banner when calling connect*Emulator #9055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 21, 2025
Merged

Updated to only show banner when calling connect*Emulator #9055

merged 2 commits into from
May 21, 2025
+40 −10

Conversation

maneesht
Copy link
Contributor

@maneesht maneesht commented May 21, 2025 •
edited
Loading

Only show emulator banner when:

  • Calling connect*Emulator
  • On Firebase Studio

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 21, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 33b8620

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
@firebase/auth Patch
@firebase/data-connect Patch
@firebase/database Patch
@firebase/firestore Patch
@firebase/functions Patch
@firebase/storage Patch
@firebase/auth-compat Patch
firebase Patch
@firebase/database-compat Patch
@firebase/firestore-compat Patch
@firebase/functions-compat Patch
@firebase/storage-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_vertexai_responses.sh should be updated to clone the latest version of the responses: v13.0

@maneesht maneesht requested a review from a team as a code owner May 21, 2025 22:47
@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 21, 2025 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/auth

    TypeBase (35ad526)Merge (c3982dd)Diff
    browser193 kB193 kB+60 B (+0.0%)
    cordova166 kB166 kB+60 B (+0.0%)
    main147 kB147 kB+44 B (+0.0%)
    module193 kB193 kB+60 B (+0.0%)
    react-native165 kB165 kB+44 B (+0.0%)

  • @firebase/auth-cordova

    TypeBase (35ad526)Merge (c3982dd)Diff
    browser166 kB166 kB+60 B (+0.0%)
    module166 kB166 kB+60 B (+0.0%)

  • @firebase/auth-web-extension

    TypeBase (35ad526)Merge (c3982dd)Diff
    browser142 kB142 kB+60 B (+0.0%)
    main159 kB159 kB+46 B (+0.0%)
    module142 kB142 kB+60 B (+0.0%)

  • @firebase/auth/internal

    TypeBase (35ad526)Merge (c3982dd)Diff
    browser204 kB204 kB+60 B (+0.0%)
    main174 kB174 kB+46 B (+0.0%)
    module204 kB204 kB+60 B (+0.0%)

  • @firebase/data-connect

    TypeBase (35ad526)Merge (c3982dd)Diff
    browser21.7 kB21.7 kB+63 B (+0.3%)
    main23.9 kB24.0 kB+47 B (+0.2%)
    module21.7 kB21.7 kB+63 B (+0.3%)

  • @firebase/database

    TypeBase (35ad526)Merge (c3982dd)Diff
    browser249 kB250 kB+59 B (+0.0%)
    main254 kB254 kB+43 B (+0.0%)
    module249 kB250 kB+59 B (+0.0%)

  • @firebase/database-compat/standalone

    TypeBase (35ad526)Merge (c3982dd)Diff
    main366 kB366 kB+43 B (+0.0%)

  • @firebase/firestore

    TypeBase (35ad526)Merge (c3982dd)Diff
    browser385 kB385 kB+63 B (+0.0%)
    main596 kB596 kB+44 B (+0.0%)
    module385 kB385 kB+63 B (+0.0%)
    react-native385 kB385 kB+62 B (+0.0%)

  • @firebase/firestore-lite

    TypeBase (35ad526)Merge (c3982dd)Diff
    browser114 kB114 kB+62 B (+0.1%)
    main157 kB157 kB+44 B (+0.0%)
    module114 kB114 kB+62 B (+0.1%)
    react-native114 kB114 kB+65 B (+0.1%)

  • @firebase/functions

    TypeBase (35ad526)Merge (c3982dd)Diff
    browser14.1 kB14.2 kB+60 B (+0.4%)
    main14.7 kB14.7 kB+44 B (+0.3%)
    module14.1 kB14.2 kB+60 B (+0.4%)

  • @firebase/storage

    TypeBase (35ad526)Merge (c3982dd)Diff
    browser58.4 kB58.5 kB+58 B (+0.1%)
    main60.0 kB60.0 kB+42 B (+0.1%)
    module58.4 kB58.5 kB+58 B (+0.1%)

  • bundle

    34 size changes

    TypeBase (35ad526)Merge (c3982dd)Diff
    auth (GoogleFBTwitterGitHubPopup)105 kB109 kB+4.36 kB (+4.2%)
    database (Append to a list of data)150 kB154 kB+4.37 kB (+2.9%)
    database (Filtering data)149 kB153 kB+4.36 kB (+2.9%)
    database (Listen for child events)165 kB170 kB+4.36 kB (+2.6%)
    database (Listen for value events + Detach listeners)165 kB170 kB+4.36 kB (+2.6%)
    database (Listen for value events)165 kB170 kB+4.36 kB (+2.6%)
    database (Read data once)165 kB169 kB+4.36 kB (+2.6%)
    database (Save data as transactions)167 kB172 kB+4.36 kB (+2.6%)
    database (Sort data)151 kB155 kB+4.36 kB (+2.9%)
    database (Write data)149 kB154 kB+4.36 kB (+2.9%)
    firestore (CSI Auto Indexing Disable and Delete)275 kB279 kB+4.36 kB (+1.6%)
    firestore (CSI Auto Indexing Enable)275 kB279 kB+4.36 kB (+1.6%)
    firestore (Persistence)307 kB311 kB+4.36 kB (+1.4%)
    firestore (Query Cursors)252 kB256 kB+4.36 kB (+1.7%)
    firestore (Query)249 kB254 kB+4.36 kB (+1.7%)
    firestore (Read data once)237 kB242 kB+4.36 kB (+1.8%)
    firestore (Read Write w Persistence)331 kB335 kB+4.36 kB (+1.3%)
    firestore (Realtime updates)239 kB244 kB+4.36 kB (+1.8%)
    firestore (Transaction)216 kB221 kB+4.36 kB (+2.0%)
    firestore (Write data)216 kB220 kB+4.36 kB (+2.0%)
    firestore-lite (Query Cursors)105 kB109 kB+4.36 kB (+4.2%)
    firestore-lite (Query)101 kB105 kB+4.36 kB (+4.3%)
    firestore-lite (Read data once)76.3 kB80.6 kB+4.36 kB (+5.7%)
    firestore-lite (Transaction)102 kB106 kB+4.36 kB (+4.3%)
    firestore-lite (Write data)85.9 kB90.2 kB+4.36 kB (+5.1%)
    functions (call)35.0 kB39.4 kB+4.36 kB (+12.5%)
    storage (getBytes)42.8 kB47.2 kB+4.36 kB (+10.2%)
    storage (getDownloadURL)44.9 kB49.2 kB+4.36 kB (+9.7%)
    storage (getMetadata)44.3 kB48.7 kB+4.36 kB (+9.8%)
    storage (list + listAll)43.8 kB48.1 kB+4.36 kB (+10.0%)
    storage (updateMetadata)44.6 kB49.0 kB+4.36 kB (+9.8%)
    storage (uploadBytes)49.5 kB53.8 kB+4.36 kB (+8.8%)
    storage (uploadBytesResumable)59.4 kB63.8 kB+4.36 kB (+7.3%)
    storage (uploadString)49.7 kB54.0 kB+4.36 kB (+8.8%)

  • firebase

    15 size changes

    TypeBase (35ad526)Merge (c3982dd)Diff
    firebase-auth-compat.js141 kB145 kB+4.12 kB (+2.9%)
    firebase-auth-cordova.js138 kB142 kB+4.45 kB (+3.2%)
    firebase-auth-web-extension.js121 kB125 kB+4.45 kB (+3.7%)
    firebase-auth.js158 kB163 kB+4.46 kB (+2.8%)
    firebase-compat.js798 kB802 kB+4.21 kB (+0.5%)
    firebase-data-connect.js18.2 kB22.7 kB+4.46 kB (+24.5%)
    firebase-database-compat.js164 kB168 kB+4.14 kB (+2.5%)
    firebase-database.js187 kB192 kB+4.46 kB (+2.4%)
    firebase-firestore-compat.js343 kB347 kB+4.13 kB (+1.2%)
    firebase-firestore-lite.js133 kB137 kB+4.46 kB (+3.4%)
    firebase-firestore.js444 kB449 kB+4.46 kB (+1.0%)
    firebase-functions-compat.js10.5 kB14.7 kB+4.15 kB (+39.3%)
    firebase-functions.js15.0 kB19.5 kB+4.48 kB (+29.9%)
    firebase-storage-compat.js40.1 kB44.2 kB+4.13 kB (+10.3%)
    firebase-storage.js46.7 kB51.1 kB+4.46 kB (+9.5%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/xFEQyjKgbX.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 21, 2025 •
edited
Loading

Size Analysis Report 1

This report is too large (193,272 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Nu1b2eD9aw.html

@hsubox76 hsubox76 merged commit b5df4ae into main May 21, 2025
50 checks passed
@hsubox76 hsubox76 deleted the mtewani/fix-emulator-banner-again branch May 21, 2025 23:20
@google-oss-bot google-oss-bot mentioned this pull request May 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avolkovi avolkovi avolkovi approved these changes

@hsubox76 hsubox76 hsubox76 approved these changes

@lisajian lisajian Awaiting requested review from lisajian lisajian is a code owner

@Xiaoshouzi-gh Xiaoshouzi-gh Awaiting requested review from Xiaoshouzi-gh Xiaoshouzi-gh is a code owner

@sam-gc sam-gc Awaiting requested review from sam-gc sam-gc is a code owner

@pashanka pashanka Awaiting requested review from pashanka pashanka is a code owner

@mansisampat mansisampat Awaiting requested review from mansisampat mansisampat is a code owner

@NhienLam NhienLam Awaiting requested review from NhienLam NhienLam is a code owner

@tonyjhuang tonyjhuang Awaiting requested review from tonyjhuang tonyjhuang is a code owner

@aashishpatil-g aashishpatil-g Awaiting requested review from aashishpatil-g aashishpatil-g is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maneesht @google-oss-bot @avolkovi @hsubox76