Firestore: firestore_client.ts: async getConfiguration() -> get configuration() #7908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1Affected Products
Test Logs |
DellaBitta
reviewed
Dec 24, 2023
| @@ -254,7 +254,7 @@ export async function setOnlineComponentProvider( | |||
| const offlineComponentProvider = await ensureOfflineComponents(client); | |||
|
|
|||
| logDebug(LOG_TAG, 'Initializing OnlineComponentProvider'); | |||
| const configuration = await client.getConfiguration(); | |||
| const configuration = await client.configuration; | |||
There was a problem hiding this comment.
You can remove the await here, right?
DellaBitta
approved these changes
Jan 2, 2024
dconeybe
deleted the
dconeybe/FirestoreClientGetConfigurationShouldNotBeAsync
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor implementation detail change in Firestore where a method was unnecessarily declared as
asyncand was change to a simple property access. This has little (if any) performance improvement but makes the code a bit clearer for future readers. No functionality was changed.