Skip to content

Optimistic one leg flow with fallback #7488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Optimistic one leg flow with fallback #7488

wants to merge 16 commits into from

Conversation

Evanition
Copy link
Contributor

@Evanition Evanition commented Jul 21, 2023

This branch contains changes related to the original optimistic one leg flow implementation for webOTP autofill.

Function overloading is NOT used here.

@changeset-bot
Copy link

changeset-bot bot commented Jul 21, 2023

⚠️ No Changeset found

Latest commit: ec94aa6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 21, 2023

Size Analysis Report 1

Affected Products

  • @firebase/auth

    • AuthErrorCodes

      Size

      TypeBase (223ac18)Merge (ae40dcf)Diff
      size40.3 kB40.5 kB+225 B (+0.6%)
      size-with-ext-deps61.0 kB61.3 kB+225 B (+0.4%)
    • debugErrorMap

      Size

      TypeBase (223ac18)Merge (ae40dcf)Diff
      size47.1 kB47.5 kB+343 B (+0.7%)
      size-with-ext-deps67.9 kB68.2 kB+343 B (+0.5%)
    • linkWithPhoneNumber

      Size

      TypeBase (223ac18)Merge (ae40dcf)Diff
      size39.8 kB40.4 kB+650 B (+1.6%)
      size-with-ext-deps60.6 kB61.2 kB+650 B (+1.1%)
    • reauthenticateWithPhoneNumber

      Size

      TypeBase (223ac18)Merge (ae40dcf)Diff
      size40.3 kB41.0 kB+650 B (+1.6%)
      size-with-ext-deps61.1 kB61.8 kB+650 B (+1.1%)
    • signInWithPhoneNumber

      Size

      TypeBase (223ac18)Merge (ae40dcf)Diff
      size40.1 kB40.9 kB+781 B (+1.9%)
      size-with-ext-deps60.9 kB61.7 kB+781 B (+1.3%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/8Npfpk0Bpa.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 21, 2023

Size Report 1

Affected Products

  • @firebase/auth

    TypeBase (223ac18)Merge (ae40dcf)Diff
    browser171 kB172 kB+1.63 kB (+1.0%)
    cordova198 kB199 kB+578 B (+0.3%)
    esm5223 kB226 kB+2.12 kB (+0.9%)
    main168 kB168 kB+578 B (+0.3%)
    module171 kB172 kB+1.63 kB (+1.0%)
    react-native182 kB184 kB+2.17 kB (+1.2%)
  • @firebase/auth-compat

    TypeBase (223ac18)Merge (ae40dcf)Diff
    browser20.2 kB21.0 kB+741 B (+3.7%)
    esm527.1 kB28.1 kB+1.02 kB (+3.8%)
    main29.6 kB30.7 kB+1.05 kB (+3.5%)
    module20.2 kB21.0 kB+741 B (+3.7%)
  • @firebase/auth/cordova

    TypeBase (223ac18)Merge (ae40dcf)Diff
    browser198 kB199 kB+578 B (+0.3%)
    module198 kB199 kB+578 B (+0.3%)
  • @firebase/auth/internal

    TypeBase (223ac18)Merge (ae40dcf)Diff
    browser182 kB183 kB+1.63 kB (+0.9%)
    esm5237 kB239 kB+2.12 kB (+0.9%)
    main204 kB204 kB+578 B (+0.3%)
    module182 kB183 kB+1.63 kB (+0.9%)
  • bundle

    TypeBase (223ac18)Merge (ae40dcf)Diff
    auth (Phone)81.1 kB81.9 kB+781 B (+1.0%)
  • firebase

    TypeBase (223ac18)Merge (ae40dcf)Diff
    firebase-auth-compat.js132 kB134 kB+1.32 kB (+1.0%)
    firebase-auth-cordova.js169 kB169 kB+573 B (+0.3%)
    firebase-auth.js142 kB144 kB+1.33 kB (+0.9%)
    firebase-compat.js774 kB775 kB+1.32 kB (+0.2%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/TGBtLluuH5.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants