Skip to content

Cleanup appcheck branch for merge #4834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 27, 2021
Merged

Cleanup appcheck branch for merge #4834

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2716c6d
App check merge.
hsubox76 Apr 26, 2021
189991b
Cleanup for merge
hsubox76 Apr 26, 2021
d3db148
Revert unrelated file
hsubox76 Apr 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/app-check/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "@firebase/app-check",
"version": "0.1.0",
"private": true,
"description": "A template package for new firebase packages",
"description": "The App Check component of the Firebase JS SDK",
"author": "Firebase <firebase-support@google.com> (https://firebase.google.com/)",
"main": "dist/index.cjs.js",
"browser": "dist/index.cjs.js",
Expand Down
11 changes: 1 addition & 10 deletions packages/firebase/rollup.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,16 +76,7 @@ const plugins = [
commonjs()
];

// bundle app-check and app-check enabled libraries in firebase
const deps = Object.keys(pkg.dependencies || {}).filter(
dep =>
![
'@firebase/app-check',
'@firebase/storage',
'@firebase/functions',
'@firebase/database'
].includes(dep)
);
const deps = Object.keys(pkg.dependencies || {});
const external = id => deps.some(dep => id === dep || id.startsWith(`${dep}/`));

/**
Expand Down
98 changes: 0 additions & 98 deletions scripts/pack-appcheck.ts
View file
Open in desktop

This file was deleted.