Rename value to docValue in RelationFilter #1844
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thebrianchen
changed the title
value to docValue in RelationFilter
mikelehen
suggested changes
Jun 4, 2019
packages/firestore/src/core/query.ts
Outdated
| @@ -533,18 +533,18 @@ export class RelationFilter extends Filter { | |||
| } | |||
| } | |||
|
|
|||
| private matchesValue(value: FieldValue): boolean { | |||
| private matchesValue(docValue: FieldValue): boolean { | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inside
matchesValue()ofRelationFilter, the document's value is passed in asvalue. This leads to some confusion becausevaluerefers to the document's value, whereasthis.valuerefers to theRelationFilter's value. ChangingvaluetodocValueshould make the code easier to understand.