Use npm ci on publish scripts #940
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I kept seeing error on the npm version command claiming that the directory was dirty. I believe this is because version of the npm used in our builder image is >7 which uses lockfileversion 2 instead of 1 checked into the repo. Using npm ci instead, but we should also think about updating the package-lock.json to lockfileversion 2.
joehan
approved these changes
Aug 11, 2021
TheIronDev
added a commit
to firebase/firebase-functions-test
that referenced
this pull request
May 5, 2022
This commit is a copy of [firebase/firebase-functions#940](firebase/firebase-functions#940)
TheIronDev
added a commit
to firebase/firebase-functions-test
that referenced
this pull request
May 5, 2022
* Use npm ci on publish scripts This commit is a copy of [firebase/firebase-functions#940](firebase/firebase-functions#940) * Update scripts/publish.sh Co-authored-by: Daniel Lee <danielylee@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I kept seeing error on the
npm versioncommand claiming that the directory was dirty.I believe this is because version of the
npmused in our builder image is >v7 which uses lockfileversion 2 instead of 1. I'm suggesting that we usenpm ciinstead, but we should also think about updating the package-lock.json to lockfileversion 2.