Skip to content

Allow SecretParams to be directly registered in v1/v2 options #1256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 6, 2022
Merged

Allow SecretParams to be directly registered in v1/v2 options #1256

merged 2 commits into from
Oct 6, 2022

Conversation

Berlioz
Copy link
Contributor

@Berlioz Berlioz commented Oct 5, 2022

open questions:

  1. do we actually not have tests corresponding to spec/v1/function-builder for the options struct in v2? or did i just not find them?
  2. do we want to introduce a helper type for (string | SecretParam)[]? My gut instinct is no since it's a user-facing composite type.

@Berlioz Berlioz requested review from taeold and inlined October 5, 2022 22:49
@taeold
Copy link
Contributor

taeold commented Oct 6, 2022

  1. looks like we don't have any spec for optionsToEndpoint but instead they are implicitly tested by each provider spec.
  2. Agreed

@taeold taeold added this to the v4 milestone Oct 6, 2022
@Berlioz Berlioz merged commit 8e71eca into launch.next Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taeold taeold taeold approved these changes

@inlined inlined Awaiting requested review from inlined

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4
Development

Successfully merging this pull request may close these issues.
2 participants
@Berlioz @taeold